Update ClusterNodeMBean interface/impl - not up to date with latest changes
(No description)
Leave a comment
The question is what needs to be done since the description of this task is missing.
A stupid fix would be to expose all the methods of the Cluster; but this is not a good practice since it should make sense to make a call remote available. You need to deal with concurrency issues (not all public methods are threadsafe by default) and various program flow issues. It could be that a public method should only be used in a certain flow and exposing them to the outside is asking for all kinds of problems.
So what I'm going to do is:
- make sure that the method names match of the mbean and its the service it exposes
- walk through the methods and see which make a logical match to be exposed as MBean and will expose them.
And then I'll sign the task off. I'll also send a mail to Jonas the recheck this task and either open it with a more elaborate description of what needs to be done so others can pick it up.
A stupid fix would be to expose all the methods of the Cluster; but this is not a good practice since it should make sense to make a call remote available. You need to deal with concurrency issues (not all public methods are threadsafe by default) and various program flow issues. It could be that a public method should only be used in a certain flow and exposing them to the outside is asking for all kinds of problems.
So what I'm going to do is:
- make sure that the method names match of the mbean and its the service it exposes
- walk through the methods and see which make a logical match to be exposed as MBean and will expose them.
And then I'll sign the task off. I'll also send a mail to Jonas the recheck this task and either open it with a more elaborate description of what needs to be done so others can pick it up.
Most of the public 'informational' methods of the cluster are now exposed.
One of the things that have been kept in mind is that the ClusterMBean doesn't abstract away from ZooKeeper (which doesn't need to be a bad thing). So all the ZK specific methods in the Cluster implementation are now also exposed in the ClusterMBean.
One of the things that have been kept in mind is that the ClusterMBean doesn't abstract away from ZooKeeper (which doesn't need to be a bad thing). So all the ZK specific methods in the Cluster implementation are now also exposed in the ClusterMBean.
Jonas:
This is the change:
https://github.com/jboner/akka/commit/d14f2f6e50649959a632bdabe90f7d475aee62fc
And you should decide what you want to be added/removed to the MBean. If you copy the method signatures that needs to be added/removed.. I can transform it to working code.
This is the change:
https://github.com/jboner/akka/commit/d14f2f6e50649959a632bdabe90f7d475aee62fc
And you should decide what you want to be added/removed to the MBean. If you copy the method signatures that needs to be added/removed.. I can transform it to working code.
Updating tickets (#967, #974, #975, #976, #980, #981, #989, #990, #992, #993, #994, #999, #1000, #1004, #1008, #1011, #1015, #1018, #1022, #1023, #1024, #1025, #1027, #1028, #1029, #1030, #1032, #1033, #1036, #1047, #1053, #1062, #1067, #1068, #1069, #1072, #1075, #1078, #1082, #1102, #1107, #1110, #1111, #1115, #1116, #1121, #1122, #1123, #1124)