#1023
  • Created on
    2011-07-13 15:50
  • Reported by
    pveentjer
  • Status
    Invalid
  • Priority
    Normal (3)
  • Assigned to
    viktorklang
  • Milestone
    2.0-M1
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Race Problem: PinnedDispatcher

There is a non atomic check/modify operation in the register method.

So it can be that a check is done if there already is an owner and no owner is found bu one thread. But then a different thread comes in and registers itself completely (so sets the owner) and now the original thread continues and also does super.register(actorRef) since result of owner.compareAndSet(null,actorRef) will be false in this particular case.

override def register(actorRef: ActorRef) = {
val actor = owner.get()
if ((actor ne null) && actorRef != actor) throw new IllegalArgumentException("Cannot register to anyone but " + actor)
owner.compareAndSet(null, actorRef) //Register if unregistered
super.register(actorRef)
}
User picture
  on 2011-07-14 02:54 *
By viktorklang
Status changed from New to Invalid
Only use is called by:

final def attach(actorRef: ActorRef) {
guard withGuard {
register(actorRef)
}
}

So completely safe
User picture
  on 2011-07-14 02:55 *
By viktorklang
Assigned to set to viktorklang
User picture
  on 2011-12-14 19:51 *
By viktorklang
Milestone changed from 2.0 to 2.0-M1
Updating tickets (#967, #974, #975, #976, #980, #981, #989, #990, #992, #993, #994, #999, #1000, #1004, #1008, #1011, #1015, #1018, #1022, #1023, #1024, #1025, #1027, #1028, #1029, #1030, #1032, #1033, #1036, #1047, #1053, #1062, #1067, #1068, #1069, #1072, #1075, #1078, #1082, #1102, #1107, #1110, #1111, #1115, #1116, #1121, #1122, #1123, #1124)