#1004
  • Created on
    2011-07-08 03:18
  • Reported by
    pveentjer
  • Status
    Duplicate
  • Priority
    Normal (3)
  • Assigned to
    -
  • Milestone
    2.0-M1
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Race Problem in Actor.actorOf

The createActor does a check and then act that is not atomic.

private[akka] def createActor(address: String, actorFactory: () ⇒ ActorRef): ActorRef = {
Address.validate(address)
registry.actorFor(address) match { // check if the actor for the address is already in the registry
case Some(actorRef) ⇒ actorRef // it is -> return it
case None ⇒ // it is not -> create it
try {
Deployer.deploymentFor(address) match {
case Deploy(_, router, _, Local) ⇒ actorFactory() // create a local actor
case deploy ⇒ newClusterActorRef(actorFactory, address, deploy)
}
} catch {
case e: DeploymentException ⇒
EventHandler.error(e, this, "Look up deployment for address [%s] falling back to local actor." format address)
actorFactory() // if deployment fails, fall back to local actors
}
}
}

So it checks if the actor exists and if not, it makes the actor. Because this behavior is not atomic (and no 'repairing' is done) there is a data race.

Inportant: The scope of this task is only to get the local stuff race free. See the
https://www.assembla.com/spaces/akka/tickets/1029-race-problem-in-actor-actorof--distributed-fix
for getting the distributed stuff right.

This task was split up so they can be solved independently.
User picture
  on 2011-07-13 14:32 *
By pveentjer
Solving this problem locally is relatively simple. You can use some lock (e.g . a striped lock to prevent unwanted contention). But the problem is when there needs to be a new clustered instance. If you want to fix it in a cluster, you need to have some kind of clustered lock in place. Or you need to do a repair and discard the instance that was created, but never should have been created.
User picture
  on 2011-07-15 05:08 *
By pveentjer
Description changed from The createActor does a chec... to The createActor does a chec...
Status changed from New to Accepted
User picture
  on 2011-07-17 10:31 *
By pveentjer
Assigned to set to pveentjer
User picture
  on 2011-07-20 04:31 *
By pveentjer
Assigned to changed from pveentjer to -none-
User picture
  on 2011-08-11 10:51 *
By Jonas Bonér
Component changed from None to cluster
User picture
  on 2011-08-12 02:02 *
By Jonas Bonér
Status changed from Accepted to Duplicate
Defined in #1099
User picture
  on 2011-12-14 19:51 *
By viktorklang
Milestone changed from 2.0 to 2.0-M1
Updating tickets (#967, #974, #975, #976, #980, #981, #989, #990, #992, #993, #994, #999, #1000, #1004, #1008, #1011, #1015, #1018, #1022, #1023, #1024, #1025, #1027, #1028, #1029, #1030, #1032, #1033, #1036, #1047, #1053, #1062, #1067, #1068, #1069, #1072, #1075, #1078, #1082, #1102, #1107, #1110, #1111, #1115, #1116, #1121, #1122, #1123, #1124)