Last.FM scrobbling date+time is wrong
Last.FM needs the time send to it in GMT, but the user may be another location. We need to determine the time difference (automatically if possible, otherwise it will have to be set via the config pages)
Leave a comment
(In revision:976) The GMT offset was not being stored within the session because session files can get locked when multiple pages are accessing it (when music is playing there are two concurrent pages being requested - the 'Now Playing' screen and the streaming page). It is also worth noting that the session variables only gets written when the page ends (which is a long time for the streaming page)
To get around this, the GMT offset is saved to the database instead of the session.
I've also added a 'modified' column to both the sys and user preferences tables which gets updated with the time that the preference was last updated. This is then used for the GMT offset to ensure that we only use it if it was calculated less than 24 horus ago so that changes in timezone (eg: in/out of DST) are picked up.
Refs* 128.
To get around this, the GMT offset is saved to the database instead of the session.
I've also added a 'modified' column to both the sys and user preferences tables which gets updated with the time that the preference was last updated. This is then used for the GMT offset to ensure that we only use it if it was calculated less than 24 horus ago so that changes in timezone (eg: in/out of DST) are picked up.
Refs* 128.
(In revision:976) The GMT offset was not being stored within the session because session files can get locked when multiple pages are accessing it (when music is playing there are two concurrent pages being requested - the 'Now Playing' screen and the streaming page). It is also worth noting that the session variables only gets written when the page ends (which is a long time for the streaming page)
To get around this, the GMT offset is saved to the database instead of the session.
I've also added a 'modified' column to both the sys and user preferences tables which gets updated with the time that the preference was last updated. This is then used for the GMT offset to ensure that we only use it if it was calculated less than 24 horus ago so that changes in timezone (eg: in/out of DST) are picked up.
Refs* 128.
To get around this, the GMT offset is saved to the database instead of the session.
I've also added a 'modified' column to both the sys and user preferences tables which gets updated with the time that the preference was last updated. This is then used for the GMT offset to ensure that we only use it if it was calculated less than 24 horus ago so that changes in timezone (eg: in/out of DST) are picked up.
Refs* 128.
(In revision:976) The GMT offset was not being stored within the session because session files can get locked when multiple pages are accessing it (when music is playing there are two concurrent pages being requested - the 'Now Playing' screen and the streaming page). It is also worth noting that the session variables only gets written when the page ends (which is a long time for the streaming page)
To get around this, the GMT offset is saved to the database instead of the session.
I've also added a 'modified' column to both the sys and user preferences tables which gets updated with the time that the preference was last updated. This is then used for the GMT offset to ensure that we only use it if it was calculated less than 24 horus ago so that changes in timezone (eg: in/out of DST) are picked up.
Refs* 128.
To get around this, the GMT offset is saved to the database instead of the session.
I've also added a 'modified' column to both the sys and user preferences tables which gets updated with the time that the preference was last updated. This is then used for the GMT offset to ensure that we only use it if it was calculated less than 24 horus ago so that changes in timezone (eg: in/out of DST) are picked up.
Refs* 128.
(In revision:1303) The time being returned from the time server is correct but we were returning this as local time using mktime when we actually want the GMT time so need to use gmmktime.
Fixes* 128
Fixes* 128
(In revision:1303) The time being returned from the time server is correct but we were returning this as local time using mktime when we actually want the GMT time so need to use gmmktime.
Fixes* 128
Fixes* 128
Updating tickets (#63, #65, #75, #84, #87, #89, #93, #185, #10, #57, #64, #69, #70, #74, #79, #80, #82, #83, #85, #86, #88, #90, #91, #96, #97, #98, #99, #100, #101, #104, #105, #109, #115, #116, #117, #120, #126, #128, #130, #131, #133, #135, #153, #163, #169, #171, #173, #179, #180, #181, #184, #187, #188, #194, #195, #198, #203, #205, #218, #220, #226, #231, #236, #239, #240, #242, #247, #252, #5, #6, #11, #20, #25, #26, #27, #29, #30, #38, #40, #42, #43, #44, #46, #49, #50, #51, #52, #53, #55, #58, #59, #60, #61, #71, #92, #102, #103, #106, #107, #108, #112, #113, #114, #118, #119, #121, #129, #137, #140, #141, #144, #145, #146, #147, #149, #150, #151, #152, #154, #156, #157, #158, #160, #161, #162, #165, #167, #168, #172, #176, #182, #183, #191, #192, #193, #196, #197, #204, #206, #210, #215, #217, #222, #228, #230, #232, #234, #235, #237, #243, #249, #1, #4, #9, #12, #13, #16, #62, #78, #164, #166, #189, #190, #199, #200, #208, #209, #211, #212, #19, #47, #48)