duplicated and weird code
The code works, but is very difficult to understand and because of the duplication, to maintain
classes: ModelUtils and ErlModelUtils
methods: findPreprocessorDef
classes: ModelUtils and ErlModelUtils
methods: findPreprocessorDef
Leave a comment
on 2010-10-12 03:09 *
By jakobc
Assigned to set to jakobc
Status changed from New to Accepted
Assigned to set to jakobc
Status changed from New to Accepted
I'll fix this (in my cleanup branch), I've grown tired of the hairy code in ErlModelUtils (and openaction, and search). It should have unit tests, too.
on 2010-10-12 04:02 *
By Vlad Dumitrescu
Cool, thanks! I tried to clean it up yesterday, but couldn't be sure how everything is hanging together...
on 2010-11-17 06:00 *
By Vlad Dumitrescu
What's the status of this issue?
on 2010-11-18 06:19 *
By Vlad Dumitrescu
Milestone changed from sprint #8 to sprint #11
Milestone changed from sprint #8 to sprint #11
on 2010-12-23 06:10 *
By Vlad Dumitrescu
Status changed from Accepted to Test
Work remaining changed from 16.0 to 0.0
Status changed from Accepted to Test
Work remaining changed from 16.0 to 0.0
on 2010-12-23 06:12 *
By Vlad Dumitrescu
closed because such "long-running" tickets aren't useful -- nothing will be done about them anyway.
We'll go through the code once in a while to clean up.
We'll go through the code once in a while to clean up.
on 2011-01-21 04:34 *
By jakobc
Status changed from New to Accepted
Status changed from New to Accepted
internalFindPreprocessorDef is a mess...
11:11:07,037 W: (ErlTextHover.java:412) : null
java.lang.NullPointerException
at org.erlide.ui.util.ErlModelUtils.internalFindPreprocessorDef(ErlModelUtils.java:174)
at org.erlide.ui.util.ErlModelUtils.findPreprocessorDef(ErlModelUtils.java:135)
at org.erlide.ui.editors.erl.hover.ErlTextHover.internalGetHoverInfo(ErlTextHover.java:395)
at org.erlide.ui.editors.erl.hover.ErlTextHover.getHoverInfo2(ErlTextHover.java:248)
at org.eclipse.jface.text.TextViewerHoverManager$4.run(TextViewerHoverManager.java:166)
11:11:07,037 W: (ErlTextHover.java:412) : null
java.lang.NullPointerException
at org.erlide.ui.util.ErlModelUtils.internalFindPreprocessorDef(ErlModelUtils.java:174)
at org.erlide.ui.util.ErlModelUtils.findPreprocessorDef(ErlModelUtils.java:135)
at org.erlide.ui.editors.erl.hover.ErlTextHover.internalGetHoverInfo(ErlTextHover.java:395)
at org.erlide.ui.editors.erl.hover.ErlTextHover.getHoverInfo2(ErlTextHover.java:248)
at org.eclipse.jface.text.TextViewerHoverManager$4.run(TextViewerHoverManager.java:166)