#611
  • Created on
    2010-10-11 20:36
  • Reported by
    Vlad Dumitrescu
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    jakobc
  • Milestone
    sprint #13 - 0.10.0
  • Plan Level
    -
  • Permission type
    None
  • Estimate
    None/Small/Medium/Large None
  • Due Date
    -

Attachments

duplicated and weird code

The code works, but is very difficult to understand and because of the duplication, to maintain

classes: ModelUtils and ErlModelUtils
methods: findPreprocessorDef
User picture
  on 2010-10-12 09:09 *
By jakobc
Assigned to set to jakobc
Status changed from New to Accepted
Assigned to set to jakobc
Status changed from New to Accepted
I'll fix this (in my cleanup branch), I've grown tired of the hairy code in ErlModelUtils (and openaction, and search). It should have unit tests, too.
User picture
  on 2010-10-12 09:09 *
By jakobc
Milestone changed from backlog to sprint #8
Milestone changed from backlog to sprint #8
User picture
  on 2010-10-12 10:02 *
By Vlad Dumitrescu
Cool, thanks! I tried to clean it up yesterday, but couldn't be sure how everything is hanging together...
User picture
  on 2010-11-17 12:00 *
By Vlad Dumitrescu
What's the status of this issue?
User picture
  on 2010-11-17 15:22 *
By jakobc
Work remaining changed from 0.0 to 16.0
Work remaining changed from 0.0 to 16.0
I've made improvements, but it's not perfect yet. Let's keep it open!
User picture
  on 2010-11-18 12:19 *
By Vlad Dumitrescu
Milestone changed from sprint #8 to sprint #11
Milestone changed from sprint #8 to sprint #11
User picture
  on 2010-12-23 12:10 *
By Vlad Dumitrescu
Status changed from Accepted to Test
Work remaining changed from 16.0 to 0.0
Status changed from Accepted to Test
Work remaining changed from 16.0 to 0.0
User picture
  on 2010-12-23 12:12 *
By Vlad Dumitrescu
closed because such "long-running" tickets aren't useful -- nothing will be done about them anyway.

We'll go through the code once in a while to clean up.
User picture
  on 2011-01-20 09:47 *
By Vlad Dumitrescu
Status changed from Test to Fixed
Status changed from Test to Fixed
Updating tickets (#617, #627, #629, #633, #638, #646, #558, #663, #516, #611, #612, #635, #647, #654, #661, #666, #678)
User picture
  on 2011-01-21 10:33 *
By jakobc
Status changed from Fixed to New
Status changed from Fixed to New
User picture
  on 2011-01-21 10:34 *
By jakobc
Status changed from New to Accepted
Status changed from New to Accepted
internalFindPreprocessorDef is a mess...

11:11:07,037 W: (ErlTextHover.java:412) : null
java.lang.NullPointerException
at org.erlide.ui.util.ErlModelUtils.internalFindPreprocessorDef(ErlModelUtils.java:174)
at org.erlide.ui.util.ErlModelUtils.findPreprocessorDef(ErlModelUtils.java:135)
at org.erlide.ui.editors.erl.hover.ErlTextHover.internalGetHoverInfo(ErlTextHover.java:395)
at org.erlide.ui.editors.erl.hover.ErlTextHover.getHoverInfo2(ErlTextHover.java:248)
at org.eclipse.jface.text.TextViewerHoverManager$4.run(TextViewerHoverManager.java:166)
User picture
  on 2011-01-21 10:34 *
By jakobc
Work remaining changed from 0.0 to 8.0
Work remaining changed from 0.0 to 8.0
User picture
  on 2011-01-21 10:37 *
By jakobc
Milestone changed from sprint #11 - 0.9.4 to sprint #13 - 0.10.0
Milestone changed from sprint #11 - 0.9.4 to sprint #13 - 0.10.0
User picture
  on 2011-01-31 08:13 *
By jakobc
Status changed from Accepted to Test
Status changed from Accepted to Test
User picture
  on 2011-03-03 11:32 *
By Vlad Dumitrescu
Status changed from Test to Fixed
Status changed from Test to Fixed
Updating tickets (#611, #630, #655, #659, #682, #687, #690, #711, #713, #717, #721, #724, #725, #727, #729, #731, #745, #644)