#2738
  • Created on
    2012-11-24 00:07
  • Reported by
    aleczorab
  • Status
    Fixed
  • Priority
    Highest (1)
  • Assigned to
    bjorn.antonsson@typesafe.com
  • Milestone
    2.1-RC3
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Issue with Eventstream.Subscribe in 2.1.0-RC2

Tested somewhat unscientifically due to lack of profiler etc at home.

Using akka 2.0.4, scala 2.9.2, Java 1.6.37 (osx 1.7), time to circa 0% cpu ~10 seconds.
using akka 2.1.0-rc2, scala 2.10.0-rc2, same jvm, ~60 seconds to 0% cpu.

Testing methodology was horrible, but good enough to see a pretty massive difference in timings.

Testing on another machine seemed to imply this was being caused by huge quantities of time dealing with hash collisions inside HashSet1.
User picture
  on 2012-11-24 00:07 *
By aleczorab
Attachment TestBuild.scala added
file:d_TqxYnCOr4P36acwqEsg8
sbt file
User picture
  on 2012-11-24 00:08 *
By aleczorab
Attachment Test.scala added
file:aB2lWAnCSr4QA9acwqjQYw
User picture
  on 2012-11-24 06:54 *
By bjorn.antonsson@typesafe.com
A quick run on my machine looked like the active time was spent in SubclassifiedIndex.mergeChangesByKey.
User picture
  on 2012-11-24 18:42 *
By viktorklang
Milestone changed from Coltrane to 2.1
User picture
  on 2012-11-24 18:42 *
By viktorklang
Priority changed from Normal (3) to Highest (1)
User picture
  on 2012-11-26 07:43 *
By bjorn.antonsson@typesafe.com
Assigned to set to bjorn.antonsson@typesafe.com
User picture
  on 2012-11-26 07:43 *
By bjorn.antonsson@typesafe.com
Status changed from New to Accepted
User picture
  on 2012-11-26 07:46 *
By bjorn.antonsson@typesafe.com
Regression confirmed:

5000 actors subscribing:
2.0.4 ~ 200 ms
2.1.0-RC2 ~ 10500 ms
User picture
  on 2012-11-26 08:36 *
By bjorn.antonsson@typesafe.com
Status changed from Accepted to Test
So a we returned more than the diff from addValue in SubclassifiedIndex, which lead to an large amount of existing values being processed and then inserted into a HashMap.

The time for 5000 actors subscribing with the fix is ~300 ms, which I think is acceptable since the index now handles classes with multiple traits, which it doesn't do in 2.0.x.
User picture
  on 2012-11-26 10:04 *
By bjorn.antonsson@typesafe.com
Status changed from Test to Fixed
In master as well
User picture
  on 2012-11-26 17:00 *
By rkuhn
Milestone changed from 2.1 to 2.1-RC3
Updating tickets (#2654, #2675, #2685, #2694, #2701, #2703, #2707, #2710, #2717, #2718, #2720, #2723, #2724, #2727, #2729, #2732, #2736, #2738, #2739, #2740)