#2277
- Created on2012-06-27 11:48
- Reported by
- StatusFixed
- PriorityNormal (3)
- Assigned to
- Milestone
- Plan Level-
- Due Date-
Calling remove on a failure detector has different meanings
When looking at rejoining I ran into the fact that the FailureDetectorPuppet thinks that remove means that the address is welcome back again, but the AccrualFailureDetector thinks that it should mean that the address is forever unavailable.
Do we really need the forever unavailable? That seems like it is something for the the cluster gossip code to handle with the unreachable set.
Do we really need the forever unavailable? That seems like it is something for the the cluster gossip code to handle with the unreachable set.
Leave a comment
on 2012-06-27 12:02 *
By Patrik Nordwall
I don't think we need the explicitRemovals in AccrualFailureDetector. Try to delete it (some test of it might need to be changed).
Note that explicitRemovals doesn't mean "forever unavailable". It comes alive again when a heartbeat is received. Anyway, just delete explicitRemovals.
Note that explicitRemovals doesn't mean "forever unavailable". It comes alive again when a heartbeat is received. Anyway, just delete explicitRemovals.
Check
Updating tickets (#939, #940, #1941, #2213, #2214, #2215, #2219, #2222, #2223, #2239, #2240, #2249, #2250, #2252, #2253, #2254, #2256, #2259, #2263, #2264, #2265, #2267, #2270, #2271, #2275, #2277, #2286, #2287, #2289, #2290, #2303, #2304, #2308, #2310, #2311, #2317, #2323, #2331, #2374, #2392, #2405, #2423, #2425, #2440, #2444, #2445, #2453, #2456, #2459, #2473, #2477, #2491, #2495, #2523, #2534, #2541, #2544, #2545, #2549, #2582, #2583, #2589, #2626)
Updating tickets (#939, #940, #1941, #2081, #2126, #2213, #2214, #2215, #2219, #2222, #2223, #2239, #2240, #2249, #2250, #2252, #2253, #2254, #2256, #2259, #2263, #2264, #2265, #2267, #2270, #2271, #2275, #2277, #2286, #2287, #2289, #2290, #2303, #2304, #2308, #2310, #2311, #2317, #2323, #2331, #2374, #2392, #2394, #2405, #2408, #2423, #2424, #2425, #2440, #2444, #2445, #2449, #2453, #2456, #2459, #2461, #2473, #2477, #2485, #2491, #2495, #2498, #2501, #2505, #2515, #2517, #2523, #2534, #2541, #2544, #2545, #2549, #2582, #2583, #2588, #2589, #2598, #2599, #2618, #2623, #2626, #2627, #2630, #2631, #2633, #2634, #2635, #2637, #2638, #2642, #2643, #2646, #2647, #2648, #2649, #2650, #2653, #2655, #2657, #2658)