Avoid gossip merge when singleton cluster
We have seen SunnyWeatherSpec fail a few times due to that initial convergence (5 nodes) are not reached in time.
Then a lot of gossip merge was going on.
I think this introduce extra delays when a few singleton nodes joins at the same time.
I'll take a look at what happens if we always consider the remote gossip newer when received by a singleton cluster.
Then a lot of gossip merge was going on.
I think this introduce extra delays when a few singleton nodes joins at the same time.
I'll take a look at what happens if we always consider the remote gossip newer when received by a singleton cluster.
Leave a comment
on 2012-06-19 05:15 *
By Jonas Bonér
That should be fine I think. It will converge to the same state regardless shortly after.
If two singleton clusters join then we take the gossip from the node that he joined to.
If two singleton clusters join then we take the gossip from the node that he joined to.
on 2012-06-19 06:59 *
By Patrik Nordwall
I think this was a good move. Works fine. I'll wait with pushing to pull request until I have merged in other things.
on 2012-06-19 07:02 *
By Jonas Bonér
Nice. Good job.
on 2012-06-20 02:44 *
By Patrik Nordwall
(In revision:dccb0ca2d7f806e46dc6f684ee9a821f778aaa95) Avoid gossip merge when singleton cluster, see #2250
Branch: wip-2250-singleton-cluster-merge-patriknw
Branch: wip-2250-singleton-cluster-merge-patriknw
Updating tickets (#939, #940, #1941, #2213, #2214, #2215, #2219, #2222, #2223, #2239, #2240, #2249, #2250, #2252, #2253, #2254, #2256, #2259, #2263, #2264, #2265, #2267, #2270, #2271, #2275, #2277, #2286, #2287, #2289, #2290, #2303, #2304, #2308, #2310, #2311, #2317, #2323, #2331, #2374, #2392, #2405, #2423, #2425, #2440, #2444, #2445, #2453, #2456, #2459, #2473, #2477, #2491, #2495, #2523, #2534, #2541, #2544, #2545, #2549, #2582, #2583, #2589, #2626)
Updating tickets (#939, #940, #1941, #2081, #2126, #2213, #2214, #2215, #2219, #2222, #2223, #2239, #2240, #2249, #2250, #2252, #2253, #2254, #2256, #2259, #2263, #2264, #2265, #2267, #2270, #2271, #2275, #2277, #2286, #2287, #2289, #2290, #2303, #2304, #2308, #2310, #2311, #2317, #2323, #2331, #2374, #2392, #2394, #2405, #2408, #2423, #2424, #2425, #2440, #2444, #2445, #2449, #2453, #2456, #2459, #2461, #2473, #2477, #2485, #2491, #2495, #2498, #2501, #2505, #2515, #2517, #2523, #2534, #2541, #2544, #2545, #2549, #2582, #2583, #2588, #2589, #2598, #2599, #2618, #2623, #2626, #2627, #2630, #2631, #2633, #2634, #2635, #2637, #2638, #2642, #2643, #2646, #2647, #2648, #2649, #2650, #2653, #2655, #2657, #2658)