#1368
  • Created on
    2012-11-30 12:52
  • Reported by
    maddentim
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    maddentim
  • Milestone
    2.3
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Eliminate unneed blank space character from show_date_tag

When actions that have a "Show in x" deferred message, there is an extra space added on the end causing the highlighting to extend too far.

I have removed the space in this commit: https://github.com/maddentim/tracks/commit/13e10bf768d97402d27e1aa213ab1c730b9ef129

This commit has been included in this pull request: https://github.com/TracksApp/tracks/pull/123
User picture
  on 2012-11-30 15:49 *
By zoombody
If you put the proper notation in your commit message, Assembla will automatically update the ticket when the code is committed to the Tracks repo. See the Assembla documentation and commit 33c3c57/ticket #1340 for an example.
User picture
  on 2012-11-30 15:52 *
By zoombody
Assigned to set to maddentim
Status changed from New to Accepted
Assigned to set to maddentim
Status changed from New to Accepted
Another tip: if you mark the ticket as "accepted" and assign the ticket to yourself it will be clear to others that you've got it handled and while they're free to review it, they don't need to worry about it.
User picture
  on 2012-11-30 16:19 *
By maddentim
Type set to defect
Version set to git-devel
Component changed from None to Functionality (app)
Milestone set to 2.3
Type set to defect
Version set to git-devel
Component changed from None to Functionality (app)
Milestone set to 2.3
User picture
  on 2012-11-30 16:19 *
By maddentim
Type set to defect
Version set to git-devel
Component changed from None to Functionality (app)
Milestone set to 2.3
Type set to defect
Version set to git-devel
Component changed from None to Functionality (app)
Milestone set to 2.3
User picture
  on 2012-11-30 16:22 *
By maddentim
I pushed new commits in separate branches with improved commit messages. The nice thing about single commits in a pull request is the pull request message gets updated with your commit message, which is nice! I put the Close #ticket_number in the message. I like that too!
User picture
  on 2012-11-30 16:22 *
By maddentim
I pushed new commits in separate branches with improved commit messages. The nice thing about single commits in a pull request is the pull request message gets updated with your commit message, which is nice! I put the Close #ticket_number in the message. I like that too!
User picture
  on 2012-12-01 03:07 *
By Anonymous
Status changed from Accepted to Fixed
Status changed from Accepted to Fixed
(In tracks-tickets:f7f8b79f5b37a8cc941d47b203fe0c18985fb8b5) Eliminating unneeded blank space character from show_date_tag

The space character causes the 'Show in x period' background color to
run into the todo description.

Closes #1368

Branch: master