#934
  • Created on
    2011-06-16 13:31
  • Reported by
    Jonas Bonér
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    pveentjer
  • Milestone
    2.0-M1
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Tests for cluster router [R] - Where R = [Direct, RoundRobin, Random]

Start with with finishing off the already started tests for RoundRobin.
Put all the tests in src/test/akka/cluster/routing/* with one directory per test case.
Only test stateless actors.

1. Configure up test actor in the *.conf file as clustered actor:
akka.actor.deployment.service-hello.router = "round-robin"
akka.actor.deployment.service-hello.clustered.replicas = 1

In 'replicas' element: test 1-3 replicas as well as "auto" (meaning autoscaling).
See the akka-reference.conf for doc on the config file.

2. Make sure that the actor is automatically deployed and instantiated on all the nodes

3. Make sure router works as expected by sending messages to the actor (ClusterActorRef), receive replies containing info about the node it was replied on:
https://github.com/jboner/akka/blob/master/akka-cluster/src/test/scala/akka/cluster/routing/roundrobin_2_replicas/RoundRobin2ReplicasMultiJvmSpec.scala#L26
https://github.com/jboner/akka/blob/master/akka-cluster/src/test/scala/akka/cluster/routing/roundrobin_2_replicas/RoundRobin2ReplicasMultiJvmSpec.scala#L105

4. Shut down one of the nodes with a replica: node.shutdown() and let the fail-over of the failing actor happen. In order for fail-over to work you need more nodes running than the configured replica count in the config.

5. Test that the ClusterActorRef reference still works. Now utilizing the new node instead of the failing node.

6. Anything else you can think of we should add here?

Comments:
  • Direct router is point to point. Should not fail over but if replica node crashes then it should yield an error in the actor ref. (don't think this is impl. but write test for it).
  • Random is hard to test. Let's try to think it through. Thoughts?
  • FYI: The underlying method that the deployer is invoking is Cluster.store(actorRef, replicationFactor, serializer). This one stores the actor in ZK and also sends out internal message to all nodes to "check out" actor and instantiate it locally as remotely available actor (LocalActorRef) on the replica nodes.
User picture
  on 2011-06-25 17:41 *
By Jonas Bonér
Updating tickets (#769, #774, #875, #889, #917, #920, #928, #929, #930, #931, #932, #933, #934, #935, #936, #938, #939, #940, #941, #942, #943, #944, #951, #958, #959, #960, #962, #630, #870, #891, #895)
User picture
  on 2011-06-27 11:28 *
By Jonas Bonér
Description set to Start with with finishing o...
User picture
  on 2011-07-06 13:02 *
By Jonas Bonér
Summary changed from Tests for cluster router [R] - Where R = [Direct, RoundRobin, Random, ConsistentHashing] to Tests for cluster router [R] - Where R = [Direct, RoundRobin, Random]
User picture
  on 2011-07-07 19:58 *
By pveentjer
Description changed from Start with with finishing o... to Start with with finishing o...
User picture
  on 2011-07-29 10:23 *
By pveentjer
Status changed from New to Accepted
User picture
User picture
  on 2011-08-02 10:13 *
By pveentjer
Assigned to changed from pveentjer to viktorklang
Status changed from Accepted to Test
User picture
  on 2011-08-04 22:10 *
By viktorklang
Assigned to changed from viktorklang to pveentjer
Reviewed :-)
User picture
User picture
  on 2011-08-07 20:55 *
By pveentjer
Assigned to changed from pveentjer to viktorklang
User picture
  on 2011-08-07 20:58 *
By viktorklang
Assigned to changed from viktorklang to pveentjer
Good
User picture
  on 2011-08-08 21:02 *
By pveentjer
Assigned to changed from pveentjer to viktorklang
H viktor,

is this task completed?
User picture
  on 2011-08-09 14:10 *
By viktorklang
Assigned to changed from viktorklang to pveentjer
I've reviewed the code, so if it does what it's supposed to it's done.
User picture
  on 2011-08-09 14:13 *
By pveentjer
Status changed from Test to Fixed
User picture
  on 2011-12-15 02:52 *
By viktorklang
Milestone changed from 2.0 to 2.0-M1
Updating tickets (#818, #821, #823, #836, #842, #854, #856, #865, #866, #867, #868, #869, #871, #872, #873, #877, #878, #879, #885, #888, #889, #890, #894, #910, #911, #917, #923, #924, #925, #926, #927, #928, #930, #931, #932, #933, #934, #936, #937, #952, #955, #957, #958, #959, #960, #961, #964, #965, #966)