#964
  • Created on
    2011-06-23 07:16
  • Reported by
    Jonas Bonér
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    pveentjer
  • Milestone
    2.0-M1
  • Plan Level
    -
  • Due Date
    -

Attachments

Rename reply_? to tryReply or attemptReply

From user:

Can I suggest that the naming of the "reply_?" method is neither idiomatic scala, nor naturally obvious what it does (it looks like Ruby but doesn't follow their convention of when to call a method foo_?). 

Could I suggest tryReply or attemptReply instead?
User picture
  on 2011-07-06 04:36 *
By Jonas Bonér
Should we just stick to replySafe and replyUnsafe?
User picture
  on 2011-07-16 04:04 *
By pveentjer
Assigned to set to pveentjer
User picture
  on 2011-07-16 04:04 *
By pveentjer
Status changed from New to Accepted
User picture
  on 2011-07-17 00:41 *
By pveentjer
The reply method is still called reply and fails with an IllegalStateException.

The reply_? has now been renamed to tryReply. Try prefix is useful if you want to caller to know that a boolean value is returned where he can deal with instead of an exception. Same goes for the timeout methods of a lot of java concurrency structures. You have the foo (e.g await) and the tryFoo (tryAwait).
User picture
  on 2011-07-17 01:41 *
By pveentjer
Assigned to changed from pveentjer to viktorklang
Status changed from Accepted to Test
https://github.com/jboner/akka/commit/7983a66f681468432171d6c4391682c2840ba02c
User picture
  on 2011-07-19 03:23 *
By viktorklang
Assigned to changed from viktorklang to pveentjer
Status changed from Test to Fixed
User picture
  on 2011-12-14 18:52 *
By viktorklang
Milestone changed from 2.0 to 2.0-M1
Updating tickets (#818, #821, #823, #836, #842, #854, #856, #865, #866, #867, #868, #869, #871, #872, #873, #877, #878, #879, #885, #888, #889, #890, #894, #910, #911, #917, #923, #924, #925, #926, #927, #928, #930, #931, #932, #933, #934, #936, #937, #952, #955, #957, #958, #959, #960, #961, #964, #965, #966)