#1450
  • Created on
    2013-11-30 18:25
  • Reported by
    maddentim
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    -
  • Milestone
    2.3
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Mobile buttons broken

When I click on any of the buttons on a mobile todo view page other than the edit button, I get redirected to the login page, even though I am already logged in. Once I log in, the action I was attempting has not been executed. This page that has buttons for edit, star, and defer options.

I have looked into it a bit, but was not able to find the root cause. This used to work but seems to have regressed at some point. The page is created by the view app/views/todos/show.m.erb.
User picture
  on 2013-11-30 18:25 *
By maddentim
Version changed from 2.0 to git-master
Version changed from 2.0 to git-master
User picture
  on 2013-11-30 18:25 *
By maddentim
Type set to defect
Type set to defect
User picture
  on 2013-11-30 18:25 *
By maddentim
Component set to Mobile interface
Component set to Mobile interface
User picture
  on 2014-01-02 08:34 *
By lrbalt
problem looks to be in the error "Can't verify CSRF token authenticity"

there should be a token in the form...
User picture
  on 2014-01-02 11:09 *
By maddentim
Do we need to add

<%= csrf_meta_tag %>

to the app/views/layouts/mobile.m.erb ?
User picture
  on 2014-01-02 11:41 *
By lrbalt
Assigned to set to lrbalt
Status changed from New to Fixed
Assigned to set to lrbalt
Status changed from New to Fixed

In tracks-tickets:77778da0f80ab6d4b196f775c57af4109559df13 fix #1450 by adding CSRF-token to the mobile forms

Committed to: tracks-tickets

User picture
  on 2014-01-02 11:42 *
By lrbalt
Assigned to changed from lrbalt to -none-
Status changed from Fixed to New
Assigned to changed from lrbalt to -none-
Status changed from Fixed to New
I fixed it by including the csrf tag as a hidden field

setting meta tag does not work, it is used by rails-js and ajax, but not for ordinary html forms iirc
User picture
  on 2014-01-02 11:43 *
By lrbalt
Milestone set to 2.3
Milestone set to 2.3
User picture
  on 2014-01-02 12:02 *
By lrbalt
Status changed from New to Fixed
Status changed from New to Fixed
sorry, somehow my last comment reverted state to New, but I think it is fixed :-)
User picture
  on 2014-01-02 13:06 *
By maddentim
I can confirm that it is indeed fixed - Thank you Thank you Thank you! I shouldn't rely on those defer buttons as much as I do, but ...