#1002643
  • Created on
    2016-01-29 07:43
  • Reported by
    mlangc
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    mlangc
  • Milestone
    -
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Rename class adds surplus paren

Renaming TryRenameMe in
object TryRenameMe {
  object Listings {
    case class Info(plausiblePrices: Seq[(String, Double)] = Seq(), unplausiblePrices: Seq[(String, Double)] = Seq())
  }

  case class RegionInfo(regionName: String, listings: Listings.Info)

  case class Listings(
      forRegion: RegionInfo,
      forSupRegion: Option[RegionInfo] = None,
      forNeighbours: Seq[RegionInfo] = Seq())
}

case class TryRenameMe(
    sqmPrice: Double,
    regionName: String,
    listingCategory: String,
    listings: TryRenameMe.Listings)
results in a surplus ) to be added at the end of the file, breaking the code.
User picture
  on 2016-01-29 07:51 *
By mlangc
Note that this bug can also be reproduced with the following example:
object TryRenameMeToo {
  class Listings
}

case class TryRenameMeToo(
    buggy: TryRenameMeToo.Listings)
Performing the same refactoring operation on the reformatted code
object TryRenameMeToo {
  class Listings
}

case class TryRenameMeToo(buggy: TryRenameMeToo.Listings)
works fine though.
User picture
  on 2016-02-05 05:21 *
By mlangc
I've a hack, that I'm not particularly happy with, that fixes this bug: https://github.com/scala-ide/scala-refactoring/pull/127
User picture
User picture
  on 2016-02-18 13:41 *
By mlangc
Status changed from Accepted to Fixed
Skip tree printing for rename refactorings

This commit implements rename refactorings without employing tree printing.
The ASTs from the presentation compiler are only used to find all occurrences
of the symbol that is being renamed. This information is then used to generate
changes directly.

Fix #1002643, Fix #1002622, Fix #1001966

Branch: master
Commit: scala-ide:0d8fab7dff