I've just tried this and it works for me. A problem I do see is that the form is places on the top of the page, so if you have a lot of repeating todos and try to edit the last, you need to scroll to the top to find the edit form.

I definitely had some issues with the recurring todos stuff along the way with the jQuery migration. I thought I got everything, but without tests it's hard to be sure. Reinier, do you feel like writing some Selenium tests to make sure we don't get regressions like this again?

I think recurring todos could be on the top of my list when I try go get cucumber and selenium running

Great! Getting selenium up and running is as simple as launching script/server -e test and going to http://localhost:3000/selenium. You can edit the tests and add more in test/selenium.

Yeah, but getting selenium server up and running which interacts with cucumber is a bit more complex :-)

Ahh yes, integration...

Just look here for overview and details http://seleniumhq.org/projects/remote-control/
 
Van: Eric Allen [mailto:tracks-tickets@alerts.assembla.com]
Verzonden: vrijdag 11 december 2009 16:29
Aan: Reinier Balt
Onderwerp: [Tracks-tickets] Re: #967: Recurring Todos Broken Ticket updated


 

For what it is worth, they are broken for me too, but in a different way- I get the 'new recurring todo' form, but it refuses to create a task, saying that context is empty (even when it obviously isn't.) And then when I return to the main page I'm hosed:

Showing app/views/todos/_todo.html.erb where line #33 raised:

unknown recurrence time span selection ()

Looks like a task got incompletely created somehow?

Well, for another issue, I had to upgrade my passenger gem to the latest version to get it to run correctly. Looks like that issue was impacting this recurring todo issue. So now I am getting the overlay box with the form. I can't right now, but I will try to test creating and editing todos this week. I tried one and it didn't give me autocomplete on the project or the context. So while my original issue has been resolved, this function may need some more review.

I was working on cleaning up the recurring todos code to fix some of these issues, but without tests it's really difficult.

Related association with ticket #1006 was added

I noticed that broken js can cause the form to be incomplete. It is accepted by Tracks (which is wrong) and will cause the view to crash because it expects data that is not there. I've got some basic checks in there, but I'll add some more validation code

(In revision:38f0cf1b7a7c033b84fd18fa5fd6af40b3f114a3) adds extensive validation to recurring todos. Fixes #967

Branch: master