#1002613
  • Created on
    2015-12-13 14:50
  • Reported by
    mlangc
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    mlangc
  • Milestone
    -
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Organize imports removes import needed for nested import

Organizing imports on
import java.util.Collections

class Bug {
  import Collections.emptyList

  def test = emptyList
}
removes import java.util.Collections, breaking the code.
User picture
  on 2015-12-13 14:58 *
By mlangc
Description changed from Organizing imports on <pre... to Organizing imports on <pre...
User picture
  on 2015-12-28 10:19 *
By mlangc
Assigned to set to mlangc
User picture
  on 2015-12-28 11:45 *
By mlangc
Interestingly, if one organizes imports on
import java.util.Collections

class Bug2 {
  import java.util.Collections.emptyList

  def test = emptyList
}
import java.util.Collections is not removed, although it should be dropped. If we start with
import java.util.Collections.emptyList

class Bug3 {
  import java.util.Collections.emptyList

  def test = emptyList
}
the toplevel import java.util.Collections.emptyList is replaced with import java.util.Collections instead of being removed entirely.
User picture
User picture
  on 2016-01-04 14:23 *
By mlangc
Status changed from Accepted to Fixed
Treat nested imports more carefully

This commit overworks the way nested imports are treated when calculating
compilation unit dependencies. Prior to this commit, nested imports were
often simply ignored, resulting in breakage like ticket #1002613. To mitigate
this problem, it was necessary to add more bookkeeping to the dependency
calculation algorithm.

Fixes #1002613

Branch: master
Commit: scala-ide:5d67df7a0e