#1002501
  • Created on
    2015-07-03 15:15
  • Reported by
    mlangc
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    mlangc
  • Milestone
    Lithium 4.4
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Rename does not consider named parameters

Renaming x to xyz in
class Bug {
  def f(x: Int) = x
  def g(a: Int, b: Int) = f(x = a) + b
}
results in the broken code
class Bug {
  def f(xyz: Int) = xyz
  def g(a: Int, b: Int) = f(x = a) + b
}
if the renaming operation is initialized from f. The same rename operation leads to
class Bug {
  def f(x: Int) = x
  def g(a: Int, b: Int) = f(x = a) xyz b
}
when initialized from the call to f from g. I know that this is a long standing issue, that is even mentioned in Mircos Master Thesis, and that fixing this might not be trivial, due to AST limitations. I also found this ticket, but I have no access to it.
User picture
  on 2015-07-03 15:20 *
By mlangc
Description changed from Renaming <code>x</code> to ... to Renaming <code>x</code> to ...
User picture
  on 2015-07-04 06:47 *
By rafpok
Milestone set to Lithium 4.2
User picture
  on 2015-07-08 19:40 *
By Simon Schäfer
Component set to Refactoring
User picture
  on 2015-09-29 07:08 *
By rafpok
Milestone changed from Lithium 4.2 to Lithium 4.2.1
User picture
  on 2015-12-02 04:34 *
By wpopielarski769697
Milestone changed from Lithium 4.3 to Lithium 4.4
User picture
  on 2015-12-28 05:19 *
By mlangc
Assigned to changed from mlangc to -none-
User picture
  on 2016-02-19 00:47 *
By mlangc
Assigned to set to mlangc
User picture
  on 2016-02-24 15:18 *
By mlangc
Well, for anyone who is interested in the progress I've made so far: The performance problems that lead to support for named parameters being dropped originally have already been fixed. Basic functionality is there, but handling for class parameters (especially case classes) is still missing. Also, the code that decides which tree was selected by the user needs some updates. More details can be found here: https://github.com/mlangc/scala-refactoring/tree/1002501-rename-does-not-consider-named-parameters

I'm on vacation this weekend, but I hope that I will find be able to push this further next week.
User picture
  on 2016-02-29 15:40 *
By mlangc
I've created a PR with the code I have so far, so that you can take a look early, as we discussed last Thursday: https://github.com/scala-ide/scala-refactoring/pull/141
User picture
  on 2016-03-11 16:53 *
By mlangc
I'm now at a stage where I'd like to have your feedback: https://github.com/scala-ide/scala-refactoring/pull/141
User picture
  on 2016-03-25 05:56 *
By mlangc
Status changed from Accepted to Fixed
Correctly handle case classes owned by methods

This commit makes sure that case classes owned by methods are correctly handled
when doing rename refactorings.

Fix #1002501, Fix #1002572 together with the last commits

Branch: master
Commit: scala-ide:dd7ce5dd33