#1002371
  • Created on
    2015-01-11 17:33
  • Reported by
    Simon Schäfer
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    mlangc
  • Milestone
    -
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Method that returns owner breaks symbol finder

Find occurrences or rename refactoring operate also on the class field value when the method value is selected and vice versa. This bug occurs only if the return type of the method is the same as the type of the class.
class C {
  val value = 0
  def f = {
    val value = 0
    println(value)
    this
  }
}
User picture
  on 2015-10-07 18:40 *
By mlangc
Hmm, that's also interesting: When I change this to
class C {
  val value = 0
  def f = {
    val value = 0
    println(value)
   }
}

so that f returns Unit, the IDE doesn't allow me to do renames inside f at all.
User picture
  on 2015-10-07 18:41 *
By mlangc
Status changed from New to Accepted
User picture
  on 2015-10-07 18:41 *
By mlangc
Assigned to set to mlangc
User picture
  on 2015-10-07 18:52 *
By mlangc
I've just tested the latter in isolation (in a unit test). There renaming seems to work well in this case, so this might be related to something different. I'll investigate as soon as I fixed the error this ticket is originally about.
User picture
  on 2015-10-09 19:58 *
By mlangc
I've just pulled out the second issue into a separate ticket: https://scala-ide-portfolio.assembla.com/spaces/scala-ide/tickets/1002562-race-condition-when-trying-to-rename-variable
The first issue should be fixed by: https://github.com/scala-ide/scala-refactoring/pull/102
User picture
  on 2015-10-12 05:48 *
By mlangc
Status changed from Accepted to Fixed
Don't link local symbols to getters/setters

Fixes #1002371

Branch: master
Commit: scala-ide:4e3a23cda5