#1001912
  • Created on
    2013-10-10 05:53
  • Reported by
    Mirco Dotta
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    Simon Schäfer
  • Milestone
    Lithium
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Extract all non-UI specific logic from class scala.tools.eclipse.ui.ScalaCompletionProposal

As mentioned in this PR, we should clean-up the UI class `scala.tools.eclipse.ui.ScalaCompletionProposal`. In particular, all non-UI specific behavior should be extracted, and tests should be created for the logic that performs the text replacement when a completion proposal is selected

It's really important we do the clean-up before adding any further logic to the completion proposal engine.
User picture
  on 2013-10-10 05:54 *
By Mirco Dotta
Summary changed from Extract all non-UI specific from class scala.tools.eclipse.completions.ScalaCompletions to Extract all non-UI specific logic from class scala.tools.eclipse.completions.ScalaCompletions
User picture
  on 2013-10-10 05:55 *
By Mirco Dotta
Assigned to changed from Mirco Dotta to -none-
User picture
  on 2013-10-15 08:39 *
By Mirco Dotta
Summary changed from Extract all non-UI specific logic from class scala.tools.eclipse.completions.ScalaCompletions to Extract all non-UI specific logic from class scala.tools.eclipse.ui.ScalaCompletionProposal
User picture
  on 2013-10-15 08:39 *
By Mirco Dotta
Description changed from As mentioned [[url:https://... to As mentioned [[url:https://...
User picture
  on 2014-02-06 10:56 *
By huitseeker
Status changed from New to Accepted
User picture
  on 2014-04-26 06:32 *
By Simon Schäfer
Assigned to set to Simon Schäfer
User picture
  on 2014-05-30 05:58 *
By Simon Schäfer
Status changed from Accepted to Fixed
Split up last mixed UI/Non UI parts in ScalaCompletionProposal

The logic that computes the text that should be inserted into the
document is now completely independent from the UI which means it is
possible to test the behavior of the code with our test suite.

The only functional change this introduces is that the method

editor.selectAndReveal

is no longer implicitly called by

EditorUtils.applyChangesToFileWhileKeepSelection

It is not necessary to call this method because there is no selection
kept after a code completion, only the position of the cursor needs to
be tracked, which is already done by

EditorUtils.applyChangesToFile

Fixes #1001912

Branch: master
Commit: scala-ide:1cdd7ed078