This one is extremely difficult, even JDT and IntelliJ IDEA can not solve it. IntelliJ IDEA has a mixed solution. When there are " immediately before the */ in strings, the multi line comment is closed otherwise not. I will implement it the same way because it helps a little bit and I don't have any idea on what to do otherwise.

Sounds reasonable.

By the way, I was wondering why not having a "automatic close strategy" for multiline comments, i.e., whenever you type /**, the comment is closed right away. The Java Editor doesn't do it, so I was wondering why (there must be some issue I guess, no?).

Do you mean why there is no way to deactivate the behavior? The answer for this is that I didn't thought about it. ;) This probably results from the fact that I can't imagine why one doesn't want to have them closed automatically. I will add an option to the preferences.

What I meant is closing the comment as soon as you type /*, not after inserting the newline, i.e, /*^ ==> /*^*/

I think this behavior wouldn't be useful, because you need to manually adjust the */ in a new line, which is difficult because each time one inserts a newline a new * is placed at the beginning of the line. Next, the cursor position wouldn't be set correctly. Furthermore it would close an already closed comment again. The problem with the latter one is that it is difficult to detect if a comment is already closed, thus as for this, I wouldn't work for all cases.

Ok :)

Damn, after thinking in more detail about this, it doesn't look that bad anymore. Most of the current behavior wouldn't be that difficult to implement, even finding the end doesn't look as difficult as for the current implementation. I will look at this one again when I have more time.

Feel free to open a ticket. Though, if neither the Eclipse Java Editor nor the IntelijIDEA one do it, there my be a good reason ;-)

(In scala-ide:f655cccdf5d3febf1a42a8348e599343c76311e3) Correct behavior of multi line comments before string literals

This is not a full fix for the problem that multi line comments are not
automatically closed when they are followed by a string containing the
/ sign. It is difficult to completely solve this problem because
whenever one opens a multi line comment with / the rest of the document
does no longer contain any partitions because the comment spans the
complete content. Thus, it is not possible anymore to detect if the
closing sign */ is located inside of strings or not.

The behavior introduced solves the problem as good as possible. What it
does is it looks if the line containing a */ sign contains a quotation
mark. If this is the case it is assumed that the ending is located
inside of a string literal, thus the multi line comment is closed.

This fix doesn't work if the */ sign is located inside of multi line
string literals or if the string literals aren't even closed but it
helps at least partially.

Fixes #1001515

Branch: master

Follow up in #1001566

(In scala-ide:f655cccdf5d3febf1a42a8348e599343c76311e3) Correct behavior of multi line comments before string literals

This is not a full fix for the problem that multi line comments are not
automatically closed when they are followed by a string containing the
/ sign. It is difficult to completely solve this problem because
whenever one opens a multi line comment with / the rest of the document
does no longer contain any partitions because the comment spans the
complete content. Thus, it is not possible anymore to detect if the
closing sign */ is located inside of strings or not.

The behavior introduced solves the problem as good as possible. What it
does is it looks if the line containing a */ sign contains a quotation
mark. If this is the case it is assumed that the ending is located
inside of a string literal, thus the multi line comment is closed.

This fix doesn't work if the */ sign is located inside of multi line
string literals or if the string literals aren't even closed but it
helps at least partially.

Fixes #1001515

Branch: platform/juno