#585
  • Created on
    2010-06-23 03:28
  • Reported by
    Vlad Dumitrescu
  • Worked hours
    4.0 hours
  • Total worked hours
    4.0 hours
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    jakobc
  • Milestone
    sprint #6
  • Plan Level
    -
  • Permission type
    None
  • Estimate
    None/Small/Medium/Large None
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

mark occurences: inconsistent behaviour

Given the code :
  -module(mod).
  -define(mmm, mod).
  fff() ->
       ?mmm:fff(),
       ?MODULE:fff().

when cursor is on the definition of fff(), the other two occurences are marked. But when cursor is on any of the other two, the markings arent' correct.
User picture
  on 2010-06-23 03:48 *
By jakobc
Why stop at this? =) This is also not workiing:
-define(a, ?MODULE).
-define(b, ?a).
-define(c, ?b).

f() ->
?c:f().

Seriously, I'll fix this issue by generalizing the handling for the Open Action a bit.
User picture
  on 2010-06-23 03:51 *
By Vlad Dumitrescu
The point was that it should either work for every occurence, or for none of them.
User picture
  on 2010-06-23 05:17 *
By jakobc
Understood, but naturally if hover, open and completion works for macrofied modules, mark occurrences should work too. Just have to generalize a bit...
User picture
  on 2010-06-23 05:17 *
By jakobc
Assigned to set to jakobc
Status changed from New to Accepted
Work remaining changed from 0.0 to 4.0
Assigned to set to jakobc
Status changed from New to Accepted
Work remaining changed from 0.0 to 4.0
User picture
  on 2010-06-24 03:41 *
By jakobc
Hmm... this was actually harder than I thougt. The problem is that the mark occurences uses the references from the noparse (that erlang search uses), and they're ignorant of ?Macro:fun(...)-constructs, since they can't access the model to resolve macros.
I'll do a partial remedy for now. (Macros are evil kludges, by the way, and erlang would be a much, much, much better language without them.)
User picture
  on 2010-06-24 04:59 *
By jakobc
Child association with ticket #131 was added
User picture
  on 2010-06-24 05:05 *
By jakobc
Status changed from Accepted to Test
Status changed from Accepted to Test
User picture
  on 2010-08-10 01:31 *
By Vlad Dumitrescu
Milestone changed from backlog to current work
Milestone changed from backlog to current work
Updating tickets (#502, #137, #585, #519, #572, #512)
User picture
  on 2010-09-08 04:16 *
By Vlad Dumitrescu
Milestone changed from current work to sprint #6
Milestone changed from current work to sprint #6
Updating tickets (#502, #137, #585, #519, #572, #512)
User picture
  on 2010-10-15 04:41 *
By Vlad Dumitrescu
Status changed from Test to Fixed
Work remaining changed from 4.0 to 0.0
Status changed from Test to Fixed
Work remaining changed from 4.0 to 0.0
Updating tickets (#502, #137, #585, #592, #519, #572, #595, #512, #602, #562, #593, #605)