#651
  • Created on
    2010-09-17 14:41
  • Reported by
    hoffrocket
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    eltimn
  • Milestone
    2.1-RC3
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

MongoListField in 2.8.0 does not deserialize correctly

There's a bug in setFromDBObject caused by the change in scala 2.8.0 SetLike collections where .map returns a Set rather than an Iterable.

This causes ordering to be lost and duplicate values to be removed.
User picture
  on 2010-09-17 15:54 *
By eltimn
I was actually looking at this yesterday and was going to submit a fix for it. I didn't notice that it removed dupe values, however. To fix it I moved the call to toList up to where the keySet is returned (see below), this should fix the dupe problem as well, but tests should be added. Also, note that I commented out the tests for this class because of this, but I didn't look at it at the time.

I can have a fix for this up within a couple of hours, if you want me to handle it.

Original:

def setFromDBObject(dbo: DBObject): Box[List[ListType]] =
setBox(Full(dbo.keySet.map(k =>
dbo.get(k.toString).asInstanceOf[ListType]).toList))

Fixed:

def setFromDBObject(dbo: DBObject): Box[List[ListType]] =
setBox(Full(dbo.keySet.toList.map(k =>
dbo.get(k.toString).asInstanceOf[ListType])))
User picture
  on 2010-09-17 16:18 *
By hoffrocket
Status changed from Accepted to New
User picture
  on 2010-09-17 19:42 *
By eltimn
Assigned to changed from hoffrocket to eltimn
Status changed from New to Accepted
User picture
  on 2010-09-17 19:42 *
By eltimn
Status changed from Accepted to Test
User picture
  on 2010-09-20 11:46 *
By eltimn
Status changed from Test to Fixed
(In revision:c5b4d9cb1ee314427047195fc90fc90d6a4c5e83) Closes #651. MongoListField in 2.8.0 does not deserialize correctly

Branch: master
User picture
  on 2010-09-21 08:47 *
By Indrajit Raychaudhuri
Milestone changed from Lift 2.1 to 2.1-RC3
Updating tickets (#651, #652, #653)
User picture
  on 2010-11-28 09:45 *
By eltimn
(In revision:c5b4d9cb1ee314427047195fc90fc90d6a4c5e83) Closes #651. MongoListField in 2.8.0 does not deserialize correctly

Branch: master