#354
  • Created on
    2010-02-17 19:01
  • Reported by
    timperrett
  • Status
    Fixed
  • Priority
    Highest (1)
  • Assigned to
    dridus
  • Milestone
    2.1-RC1
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Bug with record field initialisation

There is an initialisation error with record in that the introspect method is not called if you make a new instance with the new language keyword. Basicaly, its all b0rked if you dont use createRecord
User picture
  on 2010-02-17 19:09 *
By dridus
Status changed from New to Test
On RB http://reviewboard.liftweb.net/r/214/
User picture
  on 2010-02-17 19:23 *
By dridus
Status changed from Test to Fixed
pushed to master:
http://github.com/dpp/liftweb/commit/37a59389bf65d4c558ff906427d52fb6fae5d912
User picture
  on 2010-08-21 02:44 *
By dridus
Status changed from Fixed to New
so this doesn't work in 2.8, because the order of initialization has changed. in 2.8, the object singletons for the subclass (e.g. Author) are not yet initialized and so return "null" at the time the superclass (Record) constructor is run. this means that none of the names ever get initialized.

I think we will have to reverse part of this change, and move the introspection back to createRecord. I'll bring it up on the ML, but I can't make screen support work on record as-is in 2.8, since screen wants field.name to be initialized.
User picture
  on 2010-08-24 02:23 *
By dridus
Required documentation set to ScalaDocs
Milestone set to 2.1-M2
User picture
  on 2010-08-24 05:37 *
By dridus
Status changed from New to Test
http://reviewboard.liftweb.net/r/425/

code up on rmm_wip_479_2.7 and rmm_wip_479_2.8
User picture
  on 2010-08-25 04:35 *
By dridus
Status changed from Test to Fixed