#700
  • Created on
    2011-06-21 22:27
  • Reported by
    Olivier Delalleau
  • Status
    New
  • Priority
    Lowest (5)
  • Assigned to
    Olivier Delalleau
  • Milestone
    0.6.1
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Remove KeyData.get_entry

From KeyData.get_entry's code in cmodule.py:

  • TODO This method may be removed in the future (e.g. in 0.5) since
  • its only purpose is to make sure that old KeyData objects created
  • before the 'entry' field was added are properly handled.
User picture
  on 2011-06-22 21:48 *
By nouiz
How this affect the case where we do an hg bisect before and after the new version? If it cause problem, we should wait long before removing it.
User picture
  on 2011-06-22 21:51 *
By Olivier Delalleau
Replying to [comment:1 nouiz]:
> How this affect the case where we do an hg bisect before and after the new version? If it cause problem, we should wait long before removing it.
0.5 should be long enough IMO. Worst case scenario, rm -rf your cache before each test with hg bisect.
User picture
  on 2011-06-22 23:24 *
By nouiz
0.5 won't be long. In fact it could be the next one as there seam to be interface change people want to push for them about the grad. That mean this ticket will probably be renamed 0.6... For now, I keep it to 0.5, but when we do it, we should reconsider if we waited long enought.

Erasing the cache in a bisect will work, but will cause much slower test and hg bisect and ask for manual intervention. I don't want that. So why not simply keep it for a very long time, like close to 1.0?

review the timming when 0.5 arrive.