#1002526
  • Created on
    2015-08-04 21:58
  • Reported by
    John Thywissen
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    mlangc
  • Milestone
    Lithium 4.4
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

"Organize Imports" duplicates imports

If the Scala>Editor>Organize Imports>sorting order preference includes a more-specific and less-specific package path prefix, for example "com" and "com.example", then import statements for certain packages will be duplicated when "Organize Imports" is run (twice for com.example..., in this example).
User picture
  on 2015-08-04 21:58 *
By John Thywissen
Description changed from If the _Scala>Editor>Organi... to If the _Scala>Editor>Organi...
User picture
  on 2015-08-10 21:23 *
By Simon Schäfer
Component set to Refactoring
Status changed from New to Accepted
Example to reproduce:

package a.b
class X


package a.c
class Y


package a.p

import a.b.X
import a.c.Y

class Test {

  val x: X = ???
  val y: Y = ???
}


Now add a.c and a (order is relevant) to the sorting order list.

After invoking organize imports the result is:
package a.p

import a.c.Y



import a.b.X
import a.c.Y

class Test {

  val x: X = ???
  val y: Y = ???
}


If the sorting order is different, the result of the organize imports action is slightly different but still wrong.
User picture
  on 2015-08-11 10:58 *
By rafpok
Milestone set to Lithium 4.2
User picture
  on 2015-09-01 11:32 *
By wpopielarski769697
Milestone changed from Lithium 4.2 to Lithium 4.2.1
User picture
  on 2015-09-02 17:45 *
By Simon Schäfer
Tags added auto-import
User picture
  on 2015-12-02 09:34 *
By wpopielarski769697
Milestone changed from Lithium 4.3 to Lithium 4.4
User picture
  on 2015-12-08 07:08 *
By mlangc
Assigned to set to mlangc
User picture
User picture
  on 2015-12-10 16:16 *
By mlangc
Status changed from Accepted to Fixed
Don't duplicate imports while grouping them

This commit reimplements the import grouping logic in a self contained, easily
testable function, and thereby fixes a bug, that led to the duplication of
imports if one import group was the prefix of another import group.

Note that the unit test that is added by this commit lives in exactly the same
package as the code it covers, since this allows us to access package private
APIs. We should consider doing the same for the rest of the tests, that
currently live under `scala.tools.refactoring.tests`.

Fixes #1002526

Branch: master
Commit: scala-ide:d4890f1e52