#1001692
  • Created on
    2013-04-30 17:16
  • Reported by
    japgolly
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    Simon Schäfer
  • Milestone
    Lithium 4.4
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Organize imports whitespace conflicts with format-source action

The organize-imports and the format-source actions both modify the whitespace between braces in an import line.
The problem is that they do it differently and there doesn't seem to be a preference to control it.
This is problematic because it generates fake changes in source control depending on which action the dev ran last.

Example:

  • start with this
import org.scalatest.{FreeSpec, FunSpec}


  • ctrl-shft-f : format
import org.scalatest.{ FreeSpec, FunSpec }


  • ctrl-shft-o : organize imports
import org.scalatest.{FreeSpec, FunSpec}
User picture
  on 2013-05-01 04:19 *
By Simon Schäfer
Component changed from None to Refactoring
User picture
  on 2013-12-11 12:41 *
By Simon Schäfer
Version changed from 3.0.0-210 to 3.0.2-210
Status changed from New to Accepted
User picture
  on 2013-12-11 12:42 *
By Simon Schäfer
Version changed from 3.0.2-210 to 4.0.0-211
User picture
  on 2015-03-29 14:35 *
By rafpok
Version changed from 4.0.0-211 to 4.0.0
Milestone set to Lithium
User picture
  on 2015-09-02 11:53 *
By Simon Schäfer
Tags added auto-import
User picture
  on 2015-09-03 01:53 *
By Iulian Dragos
Unfortunately Scalariform hard-codes the space, so we need to fix that in Scalariform, and add another preference setting (organize imports already has it, see related ticket)
User picture
  on 2015-09-03 01:53 *
By Iulian Dragos
BTW, this is something I get annoyed by every day, I'd love to get a fix.
User picture
  on 2015-09-23 02:00 *
By wpopielarski769697
Milestone changed from Lithium to Lithium 4.2.1
User picture
  on 2015-12-02 03:34 *
By wpopielarski769697
Milestone changed from Lithium 4.3 to Lithium 4.4
User picture
  on 2016-02-21 19:03 *
By Simon Schäfer
Assigned to set to Simon Schäfer
User picture
  on 2016-02-23 05:53 *
By Simon Schäfer
I can't reproduce this anymore. @mlangc Can you remember that you changed the behavior regarding when a space is printed in block imports?
User picture
User picture
  on 2016-02-26 09:37 *
By Simon Schäfer
Status changed from Accepted to Fixed
Allow users to specify the spacing around block imports

A new preference option is added to the Scala > Editor preference page,
which allows users to configure if they want to see spaces around a
block import. The default configuration is that the spaces are added,
because this is the behavior of scalariform (whose behavior is hardcoded
and can't be changed).

Fix #1001692

Branch: master
Commit: scala-ide:63efed278b