file:dnj5caTLyr4BamacwqjQYw
self-contained eclipse project to reproduce the issue

Mirko, is this a tough one to fix? I'm asking because I find the current behavior annoying.

By the way, I have now a different opinion than when I filed the ticket on the ideal behavior.

Organize import on the following:

package foo

class Foo {
  def foo() {
    import ctes.Ctes._
    A + B
  }
}

Should produce

package foo

class Foo {
  def foo() {
    import ctes.Ctes.{A, B}
    A + B
  }
}

And, as a bonus (which could be a separate ticket), it would be nice to have a checkbox to let the user decide if the organize import action should move imports to the top, i.e.

package foo

import ctes.Ctes.{A, B}

class Foo {
  def foo() {
    A + B
  }
}

WDYT?

I definitely want to implement this, but it has a lower priority than bug reports for me that's why I set the milestone to Enhancements :-) So, the user should be able to choose if he wants to "pull up imports to the top" or "preserve local imports" (do you have a better word for "local"?). And then the ususal options still apply, like sorting, omitting the scala prefix, etc. Ok?

Yep, that's it. And I really like the name "local import" (that's really what it is)

One more thing to consider is what should happen in the following:

import collection.mutable.ListBuffer
class Foo {
  val d = new ListBuffer[Any]
}

import collection.mutable.HashMap
class Bar {
  val d = new HashMap[Any,Any]
}

I'm not sure I like it or not that all imports are pulled to the top :)

> One more thing to consider is what should happen in the following:
> ...

Hm, I'd say that with "pull up imports to the top" they are all moved to the top, and with "preserve local imports" they just stay where they are. Maybe the local import isn't the best name in that case..

Makes sense to me.

Ticket assignment reverted due to inactivity.

currently (4.4.0 - nightly)

package acme.foo

class Foo {
  def foo() = {
    import acme.ctes.Ctes._
    A + B
  }
}

is not changed by Organize Imports
but following:

package acme.foo

class Foo {
  def foo() = {
    import acme.ctes.Ctes.{B, A}
    A + B
  }
}

is turned to

package acme.foo

import acme.ctes.Ctes.A
import acme.ctes.Ctes.B

class Foo {
  def foo() = {
    import acme.ctes.Ctes.{B, A}
    A + B
  }
}

notice that besides adding of imports below 'package' definition, import inside method is not sorted.

I would argue, that for nested imports there should be an option that control whether nested imports are removed and added to the top or if they stay the way they are.

I thought that in this ticket we could just sort {B, A} and not to promote them to overall imports so after organize imports we should get

package acme.foo

class Foo {
  def foo() = {
    import acme.ctes.Ctes.{A, B}

    A + B
  }
}

and generally sorted inner imports, so if input is:

package acme.foo

class Foo {
  def foo() = {
    import acme.ctes.Ctes.C
    import acme.ctes.Ctes.{B, A}

    A + B + C
  }
}

then output:

package acme.foo

class Foo {
  def foo() = {
    import acme.ctes.Ctes.{A, B}
    import acme.ctes.Ctes.C

    A + B + C
  }
}

Fixes Organize Imports in non-package blocks

Organize Imports is not able to rearrange imports in blocks of
codes which are not top level package one. So it is not rearrange
following imports in snippet below:
```
package acme.foo

class Foo {
def foo() = {
import acme.ctes.Ctes.C
import acme.ctes.Ctes.{ B, A }

C + B + A
}
}
```
with this fix it should turn to:
```
package acme.foo

class Foo {
def foo() = {
import acme.ctes.Ctes.{ A, B }
import acme.ctes.Ctes.C

C + B + A
}
}
```
Fixes #1001078

Branch: master
Commit: scala-ide:c170e908d5