Refactoring: 'Extract Method' and 'Extract Local' not working for methods with single line body
'Extract Method' and 'Extract Local' not working for methods with single line body.
Opening or closing brackets are deleted by mistake.
*extract method*:
extracting line 3 will result in:
the opening bracket is moved to the extracted method by mistake.
*extract variable*:
extracting the loop content becomes
closing bracket is removed by mistake.
Opening or closing brackets are deleted by mistake.
*extract method*:
def someFun2 = {
if (1+1 == 2) {
println("Math is great")
}
}
extracting line 3 will result in:
def someFun2 = {
if (1+1 == 2)extractedMethod
}
}
private def extractedMethod: Unit = {
{
println("Math is great")
}
the opening bracket is moved to the extracted method by mistake.
*extract variable*:
def someFun5 = {
if (1+1 == 2) {
println("Math is great")
}
}
extracting the loop content becomes
def someFun5 = {
val x = 1+1 == 2
if (x) {
println("Math is great")
}
closing bracket is removed by mistake.
Leave a comment
on 2010-07-31 15:04 *
By rjenster
Description changed from Extract method and extract ... to 'Extract Method' and 'Extra...
Summary changed from Extract method and extract local not working for methods with single line body to Refactoring: 'Extract Method' and 'Extract Local' not working for methods with single line body
on 2010-08-16 07:42 *
By Mirko Stocker
Assigned to changed from milessabin to misto
Status changed from New to Accepted
Updating tickets (#3255, #3262, #3271, #3277, #3279, #3287, #3313, #3317, #3318, #3320, #3329, #1000000, #1000002, #1000004, #1000005, #1000007, #1000011, #1000013, #1000018, #1000019, #1000020, #1000022, #1000023, #1000024, #1000025, #1000026, #1000028, #1000031, #1000033, #1000034, #1000037, #1000039, #1000040, #1000041, #1000057, #1000058, #1000060, #1000061, #1000063, #1000064, #1000065, #1000067, #1000070, #1000073, #1000076, #1000080, #1000082, #1000083, #1000084, #1000085, #1000087, #1000088, #1000089, #1000090, #1000092, #1000093, #1000094, #1000095, #1000097, #1000102, #1000104, #1000106, #1000108, #1000110, #1000111, #1000116, #1000124, #1000126, #1000127, #1000129, #1000132, #1000133, #1000136, #1000139, #1000143, #1000144, #1000145, #1000148, #1000149, #1000152, #1000154, #1000155, #1000157, #1000158, #1000159, #1000161, #1000169, #1000170, #1000172, #1000174, #1000176, #1000178, #1000179, #1000183, #1000185, #1000188, #1000189, #1000192, #1000196, #1000198)
These have been fixed quite some time ago..