#20
  • Created on
    2012-01-30 11:18
  • Reported by
    Benjamin Bandt-Horn
  • Worked hours
    0.99 hours
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    Benjamin Bandt-Horn
  • Milestone
    Version 1.0 release
  • Plan Level
    -
  • Due Date
    -

Attachments

Edit

Merge Requests

Checkout crashes with particular URL's, as of svn 1.7.x

URL's ending in "/" or missing "http://" or "svn://" error and crash the Checkout code of SCPlugin.

Best solution: Munge the URL before passing to svn 1.7.x?
User picture
  on 2012-01-30 14:10 *
By a_smirn
Milestone set to Version 1.0 release
User picture
  on 2012-01-31 23:05 *
By Benjamin Bandt-Horn
Status changed from New to Test
(In revision:91) Checkout had been crashing with URL's missing a scheme, or containing a trailing '/'.

Of the form:

http://subversion.assembla.com/svn/oji-nish

or

subversion.assembla.com/svn/oji-nish/

or

subversion.assembla.com/svn/oji-nish/

...now all get changed to:

http://subversion.assembla.com/svn/oji-nish/

~

That is to say, we now add a default scheme (http:// rather than svn://), and remove the trailing '/' (in the background, in the accessor, without modifying the user-input string).

test #20
User picture
  on 2012-01-31 23:10 *
By Benjamin Bandt-Horn
Reporting:
It would still be good to offer an error dialog of some sort for otherwise malformed or bad URL's (instead of just bailing).

Caveat:
This fix only pertains to URL's that are otherwise correct in the User's mind.

~

Future Enhancement:
It is also possible to extract the username and password from the URL, if that is a desired feature.

I don't like how Cornerstone handles this, however. It's too "in your face."
User picture
  on 2012-04-18 10:41 *
By Benjamin Bandt-Horn
Status changed from Test to Fixed