#674
  • Created on
    2010-10-08 11:11
  • Reported by
    eltimn
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    dchenbecker
  • Milestone
    2.2-RC1
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Propagate Menu.builder attributes to child menus when using expandAll

Menu.builder attributes are not being propagated when using expandAll.

<lift:Menu.builder
li_item:class="current"
/>

Works as expected; class="current" is added to the li tag of the
current page.

However, if you use:

<lift:Menu.builder
li_item:class="current"
expandAll="true"
/>

Then the class is not added to the li tag of the current page.
User picture
  on 2010-10-12 15:16 *
By dchenbecker
Assigned to set to dchenbecker
Status changed from New to Accepted
Work remaining changed from 0.0 to 2.0
User picture
  on 2010-10-12 15:17 *
By dchenbecker
Required documentation changed from None to ScalaDocs
Milestone set to 2.2-M1
User picture
  on 2010-10-23 12:55 *
By dchenbecker
Milestone changed from 2.2-M1 to 2.2-M2
User picture
  on 2010-10-23 15:18 *
By dchenbecker
Milestone changed from 2.2-M2 to 3.0-M1
User picture
  on 2010-10-23 15:19 *
By dchenbecker
Milestone changed from 3.0-M1 to 2.2-M1
Should be able to get this in this week
User picture
  on 2010-10-26 19:05 *
By dchenbecker
Milestone changed from 2.2-M1 to -none-
Actually, looks like I won't get to this this week due to illness
User picture
  on 2010-11-08 14:55 *
By dchenbecker
Milestone set to 2.2-M2
Should get this done this week
User picture
  on 2010-11-08 18:58 *
By dchenbecker
Status changed from Accepted to Test
review up: http://reviewboard.liftweb.net/r/485/
User picture
  on 2010-11-08 18:58 *
By dchenbecker
Work remaining changed from 2.0 to 0.0
User picture
  on 2010-11-09 02:25 *
By Anonymous
Status changed from Test to Fixed
(In revision:de8640e19908752339231b506aca3ab1bf8734d2) Issue 674: Fixed menu child expansion bug

Closes #674

This turned out to be an issue with Menu.makeMenuItem
using Loc.buildKidMenuItems, which won't expand children.
Added a spec and some other minor tweaks.

Branch: master
User picture
  on 2010-11-23 01:33 *
By Anonymous
(In revision:4a979ba779f1a35b69db0d0818a0e5c1536699d4) Issue 674: Fixed menu child expansion bug

Closes #674

This turned out to be an issue with Menu.makeMenuItem
using Loc.buildKidMenuItems, which won't expand children.
Added a spec and some other minor tweaks.

Branch: dpp_issue_714
User picture
  on 2010-11-24 23:23 *
By dchenbecker
Status changed from Fixed to New
Reports of regressions on the demo (and other sites). DPP has reverted the commit and we'll work on a new fix
User picture
  on 2010-11-24 23:59 *
By Anonymous
Status changed from New to Fixed
(In revision:06e2a79cc45c4c78ac831ea2a3edce738d3c9d19) A minor fix to the code introduced for #674

Closes #674

A copy and paste error crept in which prevented menu items
on the path from properly expanding their children.

Branch: master_2.7
User picture
  on 2010-11-25 00:02 *
By Anonymous
(In revision:253b451f28dae51610f12b01a869fb919d33bb95) A minor fix to the code introduced for #674

Closes #674

A copy and paste error crept in which prevented menu items
on the path from properly expanding their children.

Branch: master
User picture
  on 2010-11-28 15:18 *
By Anonymous
(In revision:ad60c257218f2dbb68424301d56af00e2df34ec8) Issue 674: Fixed menu child expansion bug

Closes #674

This turned out to be an issue with Menu.makeMenuItem
using Loc.buildKidMenuItems, which won't expand children.
Added a spec and some other minor tweaks.

Branch: dpp_issue_669
User picture
  on 2010-11-28 15:20 *
By Anonymous
(In revision:06e2a79cc45c4c78ac831ea2a3edce738d3c9d19) A minor fix to the code introduced for #674

Closes #674

A copy and paste error crept in which prevented menu items
on the path from properly expanding their children.

Branch: dpp_issue_669
User picture
  on 2010-11-28 15:34 *
By Anonymous
(In revision:253b451f28dae51610f12b01a869fb919d33bb95) A minor fix to the code introduced for #674

Closes #674

A copy and paste error crept in which prevented menu items
on the path from properly expanding their children.

Branch: master