#22
  • Created on
    2009-08-23 15:02
  • Reported by
    Howard Lewis Ship
  • Status
    Fixed
  • Priority
    High (2)
  • Assigned to
    stuart.halloway
  • Milestone
    -
  • Plan Level
    -
  • Permission type
    None
  • Due Date
    -

Related Tickets

Add new subtask or bug

clojure.contrib.str-utils2 is not AOT compiled

build.xml is missing the line to pre-compile the namespace.
User picture
  on 2009-08-23 15:08 *
By Howard Lewis Ship
Assigned to set to hlship
Status changed from New to Accepted
User picture
  on 2009-08-26 17:48 *
By Howard Lewis Ship
Assigned to changed from hlship to stuart.halloway
Status changed from Accepted to New
The patch addresses a number of compilation problems, and fixes things so that a number of tests that were present (but not run) are now run.

I think this is just a starting point, and we need seperate folders to identify main source code, gen classes, and tests so that we don't need so many exclude rules when identifying the namespaces to AOT compile.
User picture
  on 2009-09-16 18:28 *
By Howard Lewis Ship
Assigned to changed from stuart.halloway to hlship
Status changed from New to Accepted
User picture
  on 2009-09-16 18:28 *
By Howard Lewis Ship
Status changed from Accepted to Test
User picture
  on 2009-09-23 11:25 *
By Howard Lewis Ship
Priority changed from Normal (3) to High (2)
I'm tyring to use the Eclipse Clojure plugin, but due to this bug, clojure.contrib.repl_ln is not pre-compiled and so it doesn't work. Please take a few minutes to apply the patch!
User picture
  on 2009-09-25 17:53 *
By richhickey
what patch?
User picture
  on 2009-09-25 17:58 *
By Howard Lewis Ship
That's odd ... what did happen to the patch?

I'll regenerate it, but this is very, very odd. I remember adding it to this ticket (maybe I accidentally added it to a different ticket?).
User picture
  on 2009-09-25 18:02 *
By Howard Lewis Ship
Attachment ticket-22.patch added
file:aQpl6KQH8r3Q2KeJe5afGb: Patch file
User picture
  on 2009-09-25 18:03 *
By Howard Lewis Ship
The patch automatically AOT compiles the code; it automatically locates namespaces to compile. I also located a number of "dead" tests (tests that were not being run), some of which needed to be corrected for the move of c.c.test-is to c.test.
User picture
  on 2009-09-25 18:29 *
By richhickey
Patches must be prepared with git format-patch:

http://clojure.org/patches

Also, your patch seems to contain many + lines that look to me identical to the lines they replace, which makes it very difficult to see what is new. Any idea why that is happening?
User picture
  on 2009-09-25 18:42 *
By Howard Lewis Ship
Attachment 0001-Automatically-locate-namespaces-to-AOT-compile.patch added
file:c5gnW-QIqr3RD1eJe5afGb: patch via git format-patch
User picture
  on 2009-09-25 18:45 *
By Howard Lewis Ship
I've create the correct patch ... again, sorry for that. I was rushing.

I'm not sure if that's a spaces vs. tabs issue, or a windows/mac line endings issue.
User picture
  on 2009-09-25 19:06 *
By Howard Lewis Ship
I'm redoing the patch, unstaging the whitespace differences inside build.xml. I'll have it ready in a few minutes.
User picture
  on 2009-09-25 19:09 *
By Howard Lewis Ship
The XML editor I was using put a space before /> in empty tags, thus the changes. Ugh.
User picture
  on 2009-09-25 19:19 *
By Howard Lewis Ship
Attachment 0001-Ticket-22-patch.patch added
file:dAQ4d0QIKr3O-6eJe5afGb: Revised patch, part 1/2
User picture
  on 2009-09-25 19:19 *
By Howard Lewis Ship
Attachment 0002-Reconcile-the-patch-s-copy-of-build.xml-fixing-XML-f.patch added
file:dAVwG8QIKr3O-6eJe5afGb: Revised patch, part 2/2
User picture
  on 2009-09-25 19:20 *
By Howard Lewis Ship
Just added two new patch files that were created against the latest pull from GitHub master, and do not have the erroneous lines (an XML formatting issue). Should be much more straight forward to apply. Sorry for the trouble.
User picture
  on 2009-09-28 15:53 *
By stuart.halloway
Assigned to changed from hlship to stuart.halloway
Work remaining set to 1.0
looking at this now...
User picture
  on 2009-09-28 18:02 *
By stuart.halloway
(In revision:04a22729691863a5b7e7b1b3c6c1157a02aff3b2) compile str-utils2 and other build fixes, refs #22

Branch: master
User picture
  on 2009-09-28 18:03 *
By stuart.halloway
Status changed from Test to Fixed
Work remaining changed from 1.0 to 0.0
pushed to master (04a22729691863a5b7e7b1b3c6c1157a02aff3b2). Let me know if you see any issues.