#718

Created on
2013-07-25 17:19
Reported by
egouge
Status
Fixed (Completed)
Priority
High (2)
Assigned to
darrinc
Milestone
5.0.0
Plan Level
-
Estimate
1.0
Due Date
-

Split or Merge tool for patrols and patrol legs. Including merging two patrols into one

From Ruth:

We're seeing a common issue with data entry by the database managers (who do not always participate on the patrols), they set up the patrol as a simple patrol but realise during data entry that its actually a multi-leg patrol as the team has changed transport type. eg boat to a foot patrol to search an area behind an illegal camp. At present, this means they have to start the data entry from scratch or ignore the change in patrol type.
Would it be possible to set up a means to convert a simple patrol into a multi-leg patrol? for example in the summary window of the patrol, you click on the corresponding day, and have a patrol day split option?

https://www.assembla.com/spaces/smart-cs/messages/3142993

Leave a comment

on 2013-07-25 17:19 *

By egouge

Description changed from From Ruth: We'... to From Ruth: We're...

on 2013-08-14 22:11 *

By pkayal

Milestone set to SMART 2.0

on 2013-08-29 23:08 *

By jeffloun2

Milestone changed from SMART 2.0 to SMART FUTURE (2)

on 2013-09-12 20:57 *

By pkayal

Milestone changed from SMART FUTURE (2) to SMART 3.0

on 2015-08-10 07:04 *

By usmijuka526440

Milestone changed from Re-assiginig - Previously:SMART 3.0 OPTIONAL - not selected to Pipeline – High Priority

on 2015-08-10 07:04 *

By usmijuka526440

Priority changed from Normal (3) to High (2)

on 2015-08-13 16:19 *

By rbergl

A Split/Merge Patrol/Patrol Leg tool would be very valuable. Since the issues of merging and splitting legs and also merging and splitting patrols are related, can we combine all these issues in this one ticket?

on 2015-08-13 16:20 *

By rbergl

The title of this ticket should be edited to reflect this change.

on 2015-08-13 19:52 *

By rbergl

Also, the ability to merge separate patrols (post data entry or download) into a single patrol, whether single or multi-leg is needed.

on 2016-01-21 19:21 *

By jeffloun2

Summary changed from Change simple patrol to multi-leg patrol to Split or Merge tool for patrols and patrol legs. Including merging two patrols into one

on 2016-01-21 20:50 *

By egouge

See #725

This ticket has multiple tasks:
1) Allowing users to break a single leg patrol into multi leg patrol
- as a part of this we may want to improve our tools for splitting patrols to make it easier to move waypoints/tracks.

2) Allow users to merge two patrols creating a single or multi leg patrol

on 2016-02-28 10:15 *

By rbergl

Also, this ticket shodul include having multiple patrol types (air, water ground) on a multileg patrol.

on 2016-03-03 16:59 *

By egouge

related - #1444

on 2016-05-27 19:31 *

By pkayal

Milestone changed from Pipeline – High Priority to Watershed 2.0

on 2016-06-06 18:38 *

By egouge

The software makes the assumption that a patrol belongs to only a single type (air, water, or ground) - if we change this assumption we will need to ensure the query engines (both in desktop and connect) are updated correctly.

We will also have to figure out what icon to display in the UI for multi-type patrols.

on 2016-10-31 21:55 *

By jeffloun2

Assigned to set to jeffloun2

Status changed from New to In-Progress

on 2017-03-03 22:26 *

By jeffloun2

Status changed from In-Progress to Test

committed, merged into truck, ready for testing in 5.0

on 2017-03-07 22:05 *

By egouge

Status changed from Test to In-Progress

needs i81n & copyright

on 2017-03-14 23:00 *

By egouge

@jeffloun2 - a couple of things:
1) PatrolIntelLinkCopyContribution - still has a TODO tag in the mergePatrols function
Can you add the required functionality or remove the TODO

2) PatrolPlanLinkCopyContribution - same as above (TODO tag)

3) All i18n needs to go in org.wcs.smart.patrol.internal
I fixed this for now, but next time don't create new classes. We are not structuring our plugins that way.

on 2017-03-15 00:05 *

By jeffloun2

Status changed from In-Progress to Test

Should be cleaned up now.

on 2017-03-29 20:22 *

By jeffloun2

Assigned to changed from jeffloun2 to darrinc

on 2017-04-04 18:03 *

By darrinc

Assigned to changed from darrinc to jeffloun2

Status changed from Test to In-Progress

Using 5.0.a4 and the Example Conservation Area, I created two new patrols (see attachments) and went to merge them, Nothing appeared to happen in the application but there were errors logged.

MergePatrols.txt

Image not found...

SMART_merge1.zip
SMART_merge2.zip

on 2017-04-06 21:04 *

By jeffloun2

Assigned to changed from jeffloun2 to egouge

Status changed from In-Progress to Test

There was a bug when you selected a custom Patrol ID, fixed now.

on 2017-04-08 00:34 *

By egouge

Assigned to changed from egouge to darrinc

on 2017-04-10 18:57 *

By darrinc

Assigned to changed from darrinc to jeffloun2

Status changed from Test to In-Progress

In 5.0.a5, after the merge the geometries of the merge show only one of the patrols. Nothing is logged as an error.

on 2017-04-11 21:52 *

By jeffloun2

Assigned to changed from jeffloun2 to egouge

Status changed from In-Progress to Test

fixed above issues.
I also added code for a blank-day problem I saw. You should see blank legs now in-between existing legs if the ones you merged are not on continuous days.
Ready for testing in the next build.

on 2017-04-12 18:58 *

By egouge

Assigned to changed from egouge to darrinc

on 2017-04-12 22:14 *

By darrinc

Assigned to changed from darrinc to jeffloun2

Status changed from Test to In-Progress

In 5.0.a6, I completed basic testing and found the issues of missing patrols to be resolved. More extensive testing is still required on the metadata, waypoint, observation and patrol track components. At this point the issue is the application fully locks up when Intelligence and Planning components in the "Other" tab are populated.

Image not found...

on 2017-04-13 19:52 *

By egouge

The locking up issues is due to a session not be closed properly; as a result after doing this about 10times the application will lock up

on 2017-04-13 20:02 *

By egouge

I fixed the session closing problem.

on 2017-04-13 20:11 *

By jeffloun2

Ok, thanks, I could never really reproduce that freeze issue.

I noticed there is a problem when a patrol has: "Intelligence that was created by this patrol"

This line throws an exception in IntelligenceHibernateManager line 167:
File fileStore = new File(intelligence.getDatastoreLocation());

The Intel object doesn't have a datastore location. I'm not sure why that is, I just create a mostly blank intel item using the "create" link on the patrol's "Other" page to get this to happen. It doesn't actually break the merge process, but it give you an error in the middle of it which is not correct "patrol can't be deleted" but it actually is deleted just fine.

on 2017-04-13 20:15 *

By egouge

Related to patrol editing - I can no longer create a mutli leg patrol from the new patrol wizard:
1) create a new patrol using the wizard that is three days long and has three employees
2) select "multi-leg"
3) change leader for each new day and then try to save

UPDATE: FIXED - this must be a result of recent changes to hibernate session management

!ENTRY org.wcs.smart.patrol 4 0 2017-04-13 11:10:13.537
!MESSAGE Could not save patrol. Illegal attempt to associate a collection with two open sessions
!STACK 0
org.hibernate.HibernateException: Illegal attempt to associate a collection with two open sessions
	at org.hibernate.collection.internal.AbstractPersistentCollection.setCurrentSession(AbstractPersistentCollection.java:641)
	at org.hibernate.event.internal.OnUpdateVisitor.processCollection(OnUpdateVisitor.java:65)
	at org.hibernate.event.internal.AbstractVisitor.processValue(AbstractVisitor.java:121)
	at org.hibernate.event.internal.AbstractVisitor.processValue(AbstractVisitor.java:82)
	at org.hibernate.event.internal.AbstractVisitor.processEntityPropertyValues(AbstractVisitor.java:76)
	at org.hibernate.event.internal.AbstractVisitor.process(AbstractVisitor.java:143)
	at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.performUpdate(DefaultSaveOrUpdateEventListener.java:305)
	at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.entityIsDetached(DefaultSaveOrUpdateEventListener.java:241)
	at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.performSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:109)
	at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:90)
	at org.hibernate.internal.SessionImpl.fireSaveOrUpdate(SessionImpl.java:654)
	at org.hibernate.internal.SessionImpl.saveOrUpdate(SessionImpl.java:646)
	at org.hibernate.internal.SessionImpl.saveOrUpdate(SessionImpl.java:642)
	at org.wcs.smart.patrol.PatrolHibernateManager.savePatrol(PatrolHibernateManager.java:458)
	at org.wcs.smart.patrol.internal.ui.createpatrol.CreatePatrolWizard.performFinish(CreatePatrolWizard.java:237)
	at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:853)
	at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:438)
	at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:619)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4353)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4172)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:832)
	at org.eclipse.jface.window.Window.open(Window.java:808)
	at org.wcs.smart.patrol.internal.ui.properties.handlers.NewPatrolHandler.execute(NewPatrolHandler.java:81)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:247)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:214)
	at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:90)
	at org.eclipse.e4.tools.compat.parts.DIHandler.execute(DIHandler.java:50)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:294)
	at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
	at sun.reflect.GeneratedMethodAccessor308.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)
	at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:247)
	at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:229)
	at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
	at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:149)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:825)
	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:701)
	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$6(HandledContributionItem.java:685)
	at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:613)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4353)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4172)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
	at org.wcs.smart.SmartApp.start(SmartApp.java:47)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:483)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1438)

on 2017-04-13 21:58 *

By jeffloun2

Assigned to changed from jeffloun2 to darrinc

Status changed from In-Progress to Test

Emily fixed the issue I mentioned above, and the one she found as well, so it seems to be working correctly now for me.
Ready to test again in the next build.

on 2017-04-18 20:33 *

By darrinc

Assigned to changed from darrinc to egouge

Status changed from Test to In-Progress

In 5.0.a7, attachments in a merged patrol are not able to be opened.

============================

Image not found...

on 2017-04-19 00:49 *

By darrinc

Another issue found with 5.0.a7.

==============================
!ENTRY org.eclipse.ui 4 0 2017-04-18 15:46:37.169
!MESSAGE Unhandled event loop exception
!STACK 0
org.hibernate.exception.DataException: could not execute statement
at org.hibernate.exception.internal.SQLExceptionTypeDelegate.convert(SQLExceptionTypeDelegate.java:71)
at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:49)
at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:124)
at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:109)
at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:189)
at org.hibernate.engine.jdbc.batch.internal.NonBatchingBatch.addToBatch(NonBatchingBatch.java:59)
at org.hibernate.persister.entity.AbstractEntityPersister.insert(AbstractEntityPersister.java:3079)
at org.hibernate.persister.entity.AbstractEntityPersister.insert(AbstractEntityPersister.java:3521)
at org.hibernate.action.internal.EntityInsertAction.execute(EntityInsertAction.java:88)
at org.hibernate.engine.spi.ActionQueue.execute(ActionQueue.java:395)
at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:387)
at org.hibernate.engine.spi.ActionQueue.executeActions(ActionQueue.java:303)
at org.hibernate.event.internal.AbstractFlushingEventListener.performExecutions(AbstractFlushingEventListener.java:349)
at org.hibernate.event.internal.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:56)
at org.hibernate.internal.SessionImpl.flush(SessionImpl.java:1195)
at org.wcs.smart.patrol.internal.ui.views.MergePatrolsDialog.okPressed(MergePatrolsDialog.java:241)
at org.eclipse.jface.dialogs.Dialog.buttonPressed(Dialog.java:466)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:619)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4353)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4172)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:832)
at org.eclipse.jface.window.Window.open(Window.java:808)
at org.wcs.smart.patrol.internal.ui.views.MergePatrolsHandler.execute(MergePatrolsHandler.java:95)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:247)
at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:214)
at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:90)
at org.eclipse.e4.tools.compat.parts.DIHandler.execute(DIHandler.java:50)
at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:294)
at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:247)
at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:229)
at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:149)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:825)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:701)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$6(HandledContributionItem.java:685)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:613)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4353)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4172)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.wcs.smart.SmartApp.start(SmartApp.java:47)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
Caused by: java.sql.SQLDataException: A truncation error was encountered trying to shrink LONG VARCHAR 'Waypoint ID=0: LOCATION = Buhoma
Waypoint ID=1: LOCATION = B&' to length 32700.
at org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source)
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source)
at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown Source)
at org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown Source)
at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown Source)
at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown Source)
at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source)
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown Source)
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeLargeUpdate(Unknown Source)
at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(Unknown Source)
at com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.executeUpdate(NewProxyPreparedStatement.java:384)
at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:186)
... 75 more
Caused by: ERROR 22001: A truncation error was encountered trying to shrink LONG VARCHAR 'Waypoint ID=0: LOCATION = Buhoma
Waypoint ID=1: LOCATION = B&' to length 32700.
at org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
at org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
at org.apache.derby.iapi.types.SQLLongvarchar.normalize(Unknown Source)
at org.apache.derby.iapi.types.SQLVarchar.normalize(Unknown Source)
at org.apache.derby.iapi.types.DataTypeDescriptor.normalize(Unknown Source)
at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeColumn(Unknown Source)
at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeRow(Unknown Source)
at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore(Unknown Source)
at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(Unknown Source)
at org.apache.derby.impl.sql.execute.InsertResultSet.getNextRowCore(Unknown Source)
at org.apache.derby.impl.sql.execute.InsertResultSet.open(Unknown Source)
at org.apache.derby.impl.sql.GenericPreparedStatement.executeStmt(Unknown Source)
at org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source)
... 81 more

!ENTRY org.eclipse.ui 4 0 2017-04-18 15:46:46.330
!MESSAGE Unhandled event loop exception
!STACK 0
org.hibernate.TransactionException: nested transactions not supported
at org.hibernate.engine.transaction.spi.AbstractTransactionImpl.begin(AbstractTransactionImpl.java:152)
at org.hibernate.internal.SessionImpl.beginTransaction(SessionImpl.java:1387)
at org.wcs.smart.patrol.internal.ui.views.MergePatrolsDialog.okPressed(MergePatrolsDialog.java:178)
at org.eclipse.jface.dialogs.Dialog.buttonPressed(Dialog.java:466)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:619)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4353)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4172)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:832)
at org.eclipse.jface.window.Window.open(Window.java:808)
at org.wcs.smart.patrol.internal.ui.views.MergePatrolsHandler.execute(MergePatrolsHandler.java:95)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:247)
at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:214)
at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:90)
at org.eclipse.e4.tools.compat.parts.DIHandler.execute(DIHandler.java:50)
at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:294)
at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:247)
at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:229)
at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:149)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:825)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.handleWidgetSelection(HandledContributionItem.java:701)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.access$6(HandledContributionItem.java:685)
at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem$4.handleEvent(HandledContributionItem.java:613)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4353)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4172)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.wcs.smart.SmartApp.start(SmartApp.java:47)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
at org.eclipse.equinox.launcher.Main.run(Main.java:1465)

on 2017-04-19 01:03 *

By egouge

due to comment fields being merged into a comment field that is too long for the database; the same thing is likely to happen for objective

on 2017-04-19 01:21 *

By egouge

Status changed from In-Progress to Test

fixed;
-objective is not a problem because it is not combined; one objective from one patrol is chosen
-also added a check to ensure you cannot merge patrols that result in a patrol longer than 60 days

on 2017-04-19 19:55 *

By egouge

Assigned to changed from egouge to darrinc

on 2017-04-19 22:04 *

By darrinc

Status changed from Test to Fixed (Completed)

Both warnings/validation working as expected in 5.0.a8

Name	Size
MergePatrols.txt	10.9 KB	Added by darrinc on 2017-04-04 - Upload new version

MergePatrols.jpg	129 KB	Added by darrinc on 2017-04-04 - Upload new version

SMART_merge1.zip	1.38 KB	Added by darrinc on 2017-04-04 - Upload new version

SMART_merge2.zip	813 Bytes	Added by darrinc on 2017-04-04 - Upload new version

OtherMerge.jpg	157 KB	Added by darrinc on 2017-04-12 - Upload new version

MergePatrolAttachments.jpg	171 KB	Added by darrinc on 2017-04-18 - Upload new version

Drop the files anywhere in this page to upload them as attachments.

Add a Relation

Attachments

Related Tickets

Followers

Split or Merge tool for patrols and patrol legs. Including merging two patrols into one

Related Tickets

Add people from your team or external to follow ticket activity

Followers will receive email updates about new ticket activity or emails sent to smart-cs+718@tickets.assembla.com

Attachments

Related Tickets

Followers

Split or Merge tool for patrols and patrol legs. Including merging two patrols into one

Granting access, please wait...

Related Tickets

Child Stories

1 Closed Child Ticket

Add people from your team or external to follow ticket activity

Followers will receive email updates about new ticket activity or emails sent to smart-cs+718@tickets.assembla.com