M1 Latency related code review
Code review is required to close out a number of the latency related meta tickets: #97, #98, #99, #181
Next step for this ticket: Write a detailed test plan outlining which areas of code need to be reviewed, what tasks need to be performed, a checklist of things to check for each area of code (these should address all of the resolution criteria of the above mentioned tickets). Things to check would include (but this needs to be fleshed out properly):
- Does the code look finished (no fixmes, comments etc)
- Does the algorithm appear to follow the suggested form? Does it take into account the expected variables?
- Write a brief description of the algorithm used for each area and put it in the wiki.
- Review the output of the patest_suggested_vs_streaminfo_latency graphs
Code review with attention to specific latency parameters. Documenting implemenation approaches on wiki
#98 needs code review of interpretation of suggested latency values. A short summary description of the algorithm used should be added to the wiki as the output of this review.
#99 needs code review of interpretation of suggested latency values with specific attention to allowing the values to go to zero and not artifically limiting lowest latency.
#181 needs code review of the way stream info latencies are computed. A short summary description of the algorithm used should be added to the wiki as the output of this review.
#97 needs a code review of the way default latency values are computed for each host api. A short summary description of the algorithm used should be added to the wiki as the output of this review.
Need to write up a checklist for the code review.
Production of patest_suggested_vs_streaminfo_latency graphs for each host api and visual review of graphs according to specific criteria required for each ticket).
#99 requires review of patest_suggested_vs_streaminfo_latency graphs to check that the lowest selectable latency is in line with the algorithm observed in the code review.
#181 needs visual review of patest_suggested_vs_streaminfo_latency graphs (see criteria above.
Need to document the visual review criteria. Perform the review.
This task could be combined with the code review. I.e. Code is reviewed, graphs are generated, issues are examined.
Next step for this ticket: Write a detailed test plan outlining which areas of code need to be reviewed, what tasks need to be performed, a checklist of things to check for each area of code (these should address all of the resolution criteria of the above mentioned tickets). Things to check would include (but this needs to be fleshed out properly):
- Does the code look finished (no fixmes, comments etc)
- Does the algorithm appear to follow the suggested form? Does it take into account the expected variables?
- Write a brief description of the algorithm used for each area and put it in the wiki.
- Review the output of the patest_suggested_vs_streaminfo_latency graphs
Code review with attention to specific latency parameters. Documenting implemenation approaches on wiki
#98 needs code review of interpretation of suggested latency values. A short summary description of the algorithm used should be added to the wiki as the output of this review.
#99 needs code review of interpretation of suggested latency values with specific attention to allowing the values to go to zero and not artifically limiting lowest latency.
#181 needs code review of the way stream info latencies are computed. A short summary description of the algorithm used should be added to the wiki as the output of this review.
#97 needs a code review of the way default latency values are computed for each host api. A short summary description of the algorithm used should be added to the wiki as the output of this review.
Need to write up a checklist for the code review.
Production of patest_suggested_vs_streaminfo_latency graphs for each host api and visual review of graphs according to specific criteria required for each ticket).
#99 requires review of patest_suggested_vs_streaminfo_latency graphs to check that the lowest selectable latency is in line with the algorithm observed in the code review.
#181 needs visual review of patest_suggested_vs_streaminfo_latency graphs (see criteria above.
Need to document the visual review criteria. Perform the review.
This task could be combined with the code review. I.e. Code is reviewed, graphs are generated, issues are examined.
Leave a comment