#2793
  • Created on
    2012-12-12 03:40
  • Reported by
    rkuhn
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    Patrik Nordwall
  • Milestone
    2.1.1
  • Plan Level
    -
  • Due Date
    -

Attachments

NodeMetricSpec possibly too strict? 

[info] MetricValuesSpec:
[info] NodeMetrics.MetricValues 
[info] - must extract expected metrics for load balancing (1 millisecond)
[info] - extract expected MetricValue types for load balancing *** FAILED *** (10 milliseconds)
[info]   1007029083 was not less than or equal to 1007026176 (MetricValuesSpec.scala:43)


So it seems that the committed memory was slightly larger than the allowed max. Is that a bug somewhere or shall the test be more lenient?
User picture
  on 2012-12-12 03:50 *
By rkuhn
Milestone set to Coltrane
User picture
  on 2012-12-12 03:50 *
By rkuhn
Milestone changed from Coltrane to Current
User picture
  on 2012-12-13 03:36 *
By Patrik Nordwall
Assigned to set to Patrik Nordwall
Status changed from New to Accepted
This should not be possible, according to javadoc of java.lang.management.MemoryUsage
" The amount of used and committed memory will always be less than or equal to max if max is defined"
There is a check of this in MemoryUsage constructor

        if (max >= 0 && committed > max) {
            throw new IllegalArgumentException( "committed = " + committed +
                " should be < max = " + max);
        }


but there is another constructor in MemoryUsage that takes CompositeData parameter, and that constructor doesn't have this check.

I can't see that we do anything wrong. We grab those values from ManagementFactory.getMemoryMXBean.getHeapMemoryUsage.
I don't think it is important, so I suggest that we remove the assert that checks 'committed must be <= (max)'
OK?
User picture
  on 2012-12-17 09:33 *
By Patrik Nordwall
Status changed from Accepted to Test
User picture
  on 2012-12-18 09:59 *
By Patrik Nordwall
Status changed from Test to Fixed
User picture
  on 2013-01-29 05:39 *
By Patrik Nordwall
Milestone changed from Current to 2.1.x