#2299
  • Created on
    2012-07-02 13:32
  • Reported by
    rkuhn
  • Status
    Fixed
  • Priority
    High (2)
  • Assigned to
    drewhk
  • Milestone
    2.2-M3
  • Plan Level
    -
  • Due Date
    -

Attachments

make Failed a SystemMessage

this is forced upon us by BalancingDispatcher and bounded mailboxes, and then guaranteed delivery of system messages will be reusable
User picture
  on 2012-07-12 15:49 *
By viktorklang
I'd rather make it a system message and ride on the "guaranteed delivery" of those.
User picture
  on 2012-09-24 08:56 *
By viktorklang
Milestone changed from 2.1 to Coltrane
User picture
  on 2012-11-01 12:35 *
By viktorklang
Priority changed from Normal (3) to High (2)
User picture
  on 2012-11-09 09:18 *
By rkuhn
Assigned to set to rkuhn
User picture
  on 2012-11-09 09:18 *
By rkuhn
Status changed from New to Accepted
User picture
  on 2012-11-09 15:09 *
By rkuhn
The solution outlined in #1478 does not cover the case of a Failed being dropped due to a BoundedMailbox. Either we need to make Failed a proper SystemMessage (which will have different ordering semantics in a user-visible way), or we declare BoundedMailboxes to be required to always accept Failed messages. Both are not nice.
User picture
  on 2013-01-18 13:44 *
By viktorklang
One word: BalancingDispatcher
User picture
  on 2013-01-18 13:59 *
By rkuhn
technically those should be counted as two words …
User picture
  on 2013-01-21 13:17 *
By rkuhn
Description changed from challenges: * an overloade... to this is forced upon us by B...
Estimate changed from Small to Large
Summary changed from retry sending Failed() if it was lost to make Failed a SystemMessage
Sum of child estimates changed from 1.0 to 7.0
User picture
  on 2013-02-01 12:32 *
By rkuhn
Milestone changed from Current to Coltrane
User picture
  on 2013-02-01 12:33 *
By rkuhn
I hit some road blocks, and when I got the feeling that I’d rather rip it all out make rearrange the whole dungeon I came to the conclusion that this should be done after M1.
User picture
  on 2013-02-28 14:20 *
By drewhk
Milestone changed from Coltrane to Current
User picture
  on 2013-02-28 14:20 *
By drewhk
Assigned to changed from rkuhn to drewhk
User picture
  on 2013-03-04 13:37 *
By drewhk
Status changed from Accepted to Test
User picture
  on 2013-03-04 13:38 *
By drewhk
Made Roland's attempt working: https://github.com/akka/akka/commits/wip-2299-Failed-SysMsg-∂π

There might be possible improvements though, but the tests are at least green.
User picture
  on 2013-03-04 13:45 *
By viktorklang
Awesome!

I think it's also time to clean up the code surrounding SystemMessages, right now it's not really as maintainable as we'd like it to be.
Specifically the "var todo" etc.
User picture
  on 2013-03-04 13:56 *
By rkuhn
Yes, Endre and I came to the same conclusion: we will spend four more bytes in ActorCell (i.e. move the `todo`) to make it nicer, but not right now (https://www.assembla.com/spaces/akka/tickets/3119)
User picture
  on 2013-03-04 14:16 *
By drewhk
I have not yet opened the branch as a PR. Should I do that?
User picture
  on 2013-03-04 14:31 *
By rkuhn
yes, absolutely!
User picture
  on 2013-03-05 13:21 *
By drewhk
Status changed from Test to Accepted
User picture
  on 2013-03-12 10:21 *
By drewhk
Status changed from Accepted to Test
User picture
  on 2013-03-18 16:10 *
By drewhk
Failed on Jenkins:

https://jenkins.akka.io/job/repeat-akka-local-jdk7/488/
User picture
  on 2013-03-25 07:10 *
By rkuhn
Status changed from Test to Fixed