#37
- Created on2009-02-02 21:59
- Reported by
- StatusAccepted
- PriorityNormal (3)
- Assigned to
- Milestone-
- Plan Level-
- Due Date-
Refactoring Job Shadow -- v2
==> Lets compile out thoughts here -- Take a look at what I wrote below -- add messages to the ticket when you have an idea and we'll see how it works.
mm
============
AHS Web Development
Refactoring Job Shadow
For the advanced group of students, I want each pair to analyze Job Shadow Day. There are two main areas we want to look at: functional aspects and programmatic aspects.
Now be nice, Mr. Castle, Christian and I essentially ripped this out under duress. There are lots of problems with how it was built. I want to see what you guys can pull out and develop a set of best practices for everyone.
Two areas:
A. Functional Aspects:
- window does not go completely grey on
Confirmation boxes
- First selected item on Screen #1, doesn’t smoothly
drag in Firefox (IE?)
-
-
B. Refactoring of the Code
-
mm
============
AHS Web Development
Refactoring Job Shadow
For the advanced group of students, I want each pair to analyze Job Shadow Day. There are two main areas we want to look at: functional aspects and programmatic aspects.
Now be nice, Mr. Castle, Christian and I essentially ripped this out under duress. There are lots of problems with how it was built. I want to see what you guys can pull out and develop a set of best practices for everyone.
Two areas:
A. Functional Aspects:
- window does not go completely grey on
Confirmation boxes
- First selected item on Screen #1, doesn’t smoothly
drag in Firefox (IE?)
-
-
B. Refactoring of the Code
-
Leave a comment
on 2009-02-02 22:00 *
By sean.smorris
Assigned to set to sean.smorris
Status changed from New to Accepted
on 2009-02-02 23:13 *
By GuangYao(Patrick) Leng
well. is cool about the shawder thing on the web. if would be safer if u can log in the password and stuff.
when it comes to shading this out, check out http://collectionofdemos.appspot.com/demo/index.html and click on GlassPanelDemo. use this instead of veil image maybe
the download link: http://code.google.com/p/google-web-toolkit-incubator/wiki/Downloads?tm=2
remove the commented out stuff if possible
use some ctrl-shift-F action to get better code formatting (in all classes - aides legibility))
change failure/error messages to something more appropriate
split classes up - try not to have two in one file?
process the arrays etc that are generated by the server on the server-side? (eg creating the custom objects and passing them over so client side has less work to do.)
I like how the savestudentinfo method on server-side does the sql query/update in more legible way
get rid of unnecessary imports and other things
in class talk about extending baseModelData for 1 minute? (or is that a extjs specific thing)
thank god you guys don't need to do localization
I'd recommend you guys read over the code again, you will see many things that could be done better (I always do when I reread my code - eg better variable naming, class names, method names, local variable names etc, and method comments of the /** blah blah */ variety for easier use with eclipse's way of giving previews. And luck for duplications of code that could be socked into a method, all that basic stuff - I'm not implying that this is what shadow needs, just that it's good to keep an eye out.).
the download link: http://code.google.com/p/google-web-toolkit-incubator/wiki/Downloads?tm=2
remove the commented out stuff if possible
use some ctrl-shift-F action to get better code formatting (in all classes - aides legibility))
change failure/error messages to something more appropriate
split classes up - try not to have two in one file?
process the arrays etc that are generated by the server on the server-side? (eg creating the custom objects and passing them over so client side has less work to do.)
I like how the savestudentinfo method on server-side does the sql query/update in more legible way
get rid of unnecessary imports and other things
in class talk about extending baseModelData for 1 minute? (or is that a extjs specific thing)
thank god you guys don't need to do localization
I'd recommend you guys read over the code again, you will see many things that could be done better (I always do when I reread my code - eg better variable naming, class names, method names, local variable names etc, and method comments of the /** blah blah */ variety for easier use with eclipse's way of giving previews. And luck for duplications of code that could be socked into a method, all that basic stuff - I'm not implying that this is what shadow needs, just that it's good to keep an eye out.).