Method renaming doesn't save all modified sources

Say you rename a method at a use site. The method is correctly renamed both at the use site and at the declaration site, however only the source where the rename action is performed is saved (not saving all modified sources cause wrong errors to be displayed in the editor).

Scala IDE for Eclipse 2.1.0.nightly-2_09-201206270325-935bb63

Leave a comment

on 2012-06-29 08:45 *

By Mirko Stocker

Status changed from New to Accepted

That's interesting. My part of the refactorings don't care about saved or unsaved editors at all, so I never save any editors. As far as I know, when applying the changes LTK keeps the editors in the state they are in, so if an editor is not dirty before a refactoring, the file will be saved afterwards. I think that's quite nice, but if it leads to errors, then I agree that we better save the editors.

on 2012-07-03 09:01 *

By Mirco Dotta

Maybe the issue is that typechecking is not triggered for all updated sources?
I haven't investigate it, but the net result was that I was seeing wrong errors reported in the editor. Saving the updated files made the trick, but I'm not sure it is the right thing to do afterall...

on 2012-07-03 09:10 *

By Mirko Stocker

This here might be related: https://groups.google.com/d/msg/scala-ide-dev/bh1-gdhCpN8/sk0Jm7i0jNgJ

on 2012-07-03 09:25 *

By Mirco Dotta

I'm not sure, I don't think I've ever seen the issue reported...