#97
- Created on2012-02-01 14:29
- Reported by
- Worked hours15.5 hours
- StatusFixed
- PriorityNormal (3)
- Assigned to
- Milestone
- Plan Level-
- EstimateNone/Small/Medium/Large Small
- Due Date-
Checkout and Checkout from Assembla should create a directory with the name of space
When doing Checkout from Assembla operation, a directory with the name of the selected space should be created in the target directory and do the checkout in this directory, not in the right clicked target directory.
Leave a comment
As per Andy’s approval we should use the following behavior:
1) For Assembla repositories we should use the name after domain/svn/name for directory
For other repositories we should use the name after domain/name for directory
2) When a directory name conflict occurs, we should provide an error message to the user and stop the operation
1) For Assembla repositories we should use the name after domain/svn/name for directory
For other repositories we should use the name after domain/name for directory
2) When a directory name conflict occurs, we should provide an error message to the user and stop the operation
on 2012-02-04 18:14 *
By Cristian Amarie
implemented browse button
on 2012-02-05 17:05 *
By Cristian Amarie
revision 807
implemented directory creation and error handling for Checkout operation
implemented directory creation and error handling for Checkout operation
on 2012-02-06 22:07 *
By Cristian Amarie
revision 816
implemented space directory creation + error handling for Checkout from Assembla operation
implemented space directory creation + error handling for Checkout from Assembla operation
on 2012-02-06 22:07 *
By Cristian Amarie
Assigned to changed from Cristian Amarie to a_smirn
Status changed from New to Test
Implementation is done. Reassigning to Alexandr for test.
on 2012-02-08 22:24 *
By a_smirn
Assigned to changed from a_smirn to Cristian Amarie
Status changed from Test to Accepted
I've tested build 828 on win 7 sp1 x64. I've found the following issues:
1) "Checkout from Assembla" - although it now will create a new sub-directory with the name of the repository, you can only get the option to checkout from Assembla only if you are in the empty directory. Since checkout from Assembla already makes its own sub-directory for each repository, we should show this option in all directories, as we do with regular checkout option.
2) For naming the new sub-directory we should use the following logic:
a) For Assembla repositories we should use the name that follows right after "https://subversion.assembla.com/svn/ "
Example - if user checks out: https://subversion.assembla.com/svn/THIS IS THE NAME TO USE/trunk
Then the name of the new sub-directory should be "THIS IS THE NAME TO USE" and not "TRUNK"
b) For other repositories we should use the name that is right after domain name.
Example - if user checks out: https://subversion.google.com/THIS IS THE NAME TO USE for non-assembla/trunk
Then the name of the new sub-directory should be "THIS IS THE NAME TO USE for non-assembla" and not "TRUNK"
1) "Checkout from Assembla" - although it now will create a new sub-directory with the name of the repository, you can only get the option to checkout from Assembla only if you are in the empty directory. Since checkout from Assembla already makes its own sub-directory for each repository, we should show this option in all directories, as we do with regular checkout option.
2) For naming the new sub-directory we should use the following logic:
a) For Assembla repositories we should use the name that follows right after "https://subversion.assembla.com/svn/ "
Example - if user checks out: https://subversion.assembla.com/svn/THIS IS THE NAME TO USE/trunk
Then the name of the new sub-directory should be "THIS IS THE NAME TO USE" and not "TRUNK"
b) For other repositories we should use the name that is right after domain name.
Example - if user checks out: https://subversion.google.com/THIS IS THE NAME TO USE for non-assembla/trunk
Then the name of the new sub-directory should be "THIS IS THE NAME TO USE for non-assembla" and not "TRUNK"
on 2012-02-09 08:57 *
By Cristian Amarie
revision 830
Allow Checkout from Assembla on any directory (is creating a new directory anyways).
Checkout: Fix directory name extraction from repo URL.
Please let me know if now is ok.
Points 2a and 2b were referring to Checkout, not Checkout from Assembla, correct?
Allow Checkout from Assembla on any directory (is creating a new directory anyways).
Checkout: Fix directory name extraction from repo URL.
Please let me know if now is ok.
Points 2a and 2b were referring to Checkout, not Checkout from Assembla, correct?
on 2012-02-09 08:57 *
By Cristian Amarie
Assigned to changed from Cristian Amarie to a_smirn
Status changed from Accepted to Test
yes, correct 2a and 2b are referred to the checkout as in Checkout from Assembla we would use the name the user selects from the drop-down list.
Unfortunately, there is a third scenario:
For testing purposed I created ESVN project on googlecode hosting.
URL: https://esvn.googlecode.com/svn/trunk/
In this case we need to extract "esvn" in a third way.
Now I still got "trunk" folder created for checkout.
For testing purposed I created ESVN project on googlecode hosting.
URL: https://esvn.googlecode.com/svn/trunk/
In this case we need to extract "esvn" in a third way.
Now I still got "trunk" folder created for checkout.
on 2012-02-09 15:21 *
By Cristian Amarie
That is because of special naming convention of Google code hosting. It can be <projectname>.googlecode.com, subversion.googlecode.com/<projectname>/... or anything else.
There can be specified rules for certain types of open source websites - if we can gather (and possibly add over time) such naming rules to be applied, sure.
There can be specified rules for certain types of open source websites - if we can gather (and possibly add over time) such naming rules to be applied, sure.
I've tested the build 832 and I was able to get both checkout and checkout from Assembla to create a new sub-directory. With the checkout the name for the sub-directory was taken properly from the both cases that we have specified. I think the two cases should cover our needs for now and I will open a separate ticket where we can cover more cases as future improvements.
on 2012-02-10 16:43 *
By Cristian Amarie
Perfect. Then let's close the ticket as fixed and open others later if necessary for exceptions as described above.