#1000984
  • Created on
    2012-04-15 07:22
  • Reported by
    Simon Schäfer
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    Simon Schäfer
  • Milestone
    -
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Syntax highlighting not always working for `while`

The first `while` is not correctly detected. It has a different color. The second `while` as all the other keywords is correctly colored.
object X {
  while (true) {}
  do {} while (true)
}
User picture
  on 2012-05-06 08:22 *
By Mirco Dotta
Component changed from None to Semantic Highlight
User picture
  on 2013-01-07 05:42 *
By huitseeker
Eclipse version changed from Indigo to Indigo - Eclipse 3.7
Component changed from Semantic Highlight to Syntax Highlighting
Summary changed from semantic highlighting not always working for `while` to Syntax highlighting not always working for `while`
User picture
  on 2013-01-21 17:38 *
By Simon Schäfer
Assigned to set to Simon Schäfer
User picture
  on 2013-01-25 05:33 *
By Simon Schäfer
(In scala-ide:d5a865f071873d014ce299042041f9bc327c4793) Correct syntax highlighting for while-keyword

While syntax highlighting correctly recognizes the while-keyword as a
keyword, semantic highlighting treats it as a method. Because semantic
highlighting is activated after its syntax counterpart, it overwrites
the previous detected colors.

The new behavior omits all occurrences of LabelDef in the AST because
they don't regularly appear in Scala sources but represent while- and
do-while-keywords internally in the compiler. Hence they must not be
highlighted.

Fix #1000984

Branch: master
User picture
  on 2013-01-25 05:33 *
By Mirco Dotta
Status changed from New to Fixed
(In scala-ide:c4786905cb592f487b3a667e9984cbf7ff24bdee) Merge pull request #281 from sschaef/issue/while-highligting-correction

Correct syntax highlighting for while-keyword - Fix #1000984

Branch: master