#607
  • Created on
    2010-07-30 07:32
  • Reported by
    dchenbecker
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    dchenbecker
  • Milestone
    2.1-RC1
  • Plan Level
    -
  • Due Date
    -

Attachments

General check of code to see if we have other things broken by new 2.8.0 collections semantics

Since issue #596 came up, it would be a good idea to do a general audit of the code base to find out where else we use "projection" and make sure that the new semantics fit with our assumptions.
User picture
  on 2010-07-30 07:32 *
By dchenbecker
Related association with ticket #596 was added
User picture
  on 2010-07-31 00:40 *
By dchenbecker
Milestone changed from 2.1-M1 to 2.1-M2
User picture
  on 2010-08-25 01:47 *
By dchenbecker
Status changed from Accepted to Fixed
I checked through lift-base for any uses of view or projection in the 2.8.0 branches and the only place I found it is in net.liftweb.util.ClassHelpers.findClass:

  def findClass[C <: AnyRef](name: String, where: List[String], modifiers: List[Function1[String, String]], targetType: Class[C]): Box[Class[C]] =
  (for (
      place <- where.view;
      mod <- modifiers.view;
      val fullName = place + "." + mod(name);
      val ignore = List(classOf[ClassNotFoundException], classOf[ClassCastException], classOf[NoClassDefFoundError]);
      klass <- tryo(ignore)(Class.forName(fullName).asSubclass(targetType).asInstanceOf[Class[C]])
    ) yield klass).headOption


Since the issue only manifests itself when we are applying functions (e.g map, flatMap, etc) this doesn't appear to be a problem.