#1068
  • Created on
    2011-07-07 23:11
  • Reported by
    David Lee
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    nafg
  • Milestone
    -
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Delete with cascade fails when MapperRules.createForeignKeys_? is true

When using Mapper, cascade deletes fail when foreign keys are enabled (i.e. MapperRules.createForeignKeys_? = _ => true)

When you try to delete the one side of the many-to-one relationship, you get a referential integrity constraint violation.

The problem is in OneToMany.delete_!. It attempts to delete the current object prior to deleting the oneToManyFields. Reversing the logic (deleting the oneToManyFields first should fix the problem.

The fk-delete-cascade branch in git://github.com/leedm777/lift-sample-app.git has a spec (ForeignKeySpecs) that demonstrates the problem.

I'm using Lift 2.3.
User picture
  on 2011-07-07 23:16 *
By David Lee
The problem also exists in Lift-2.4. I've posted example in the branch fk-delete-cascade-2.4.
User picture
  on 2011-07-08 06:22 *
By dpp
Status changed from New to Invalid
Please discuss issues on the lift mailing list before opening tickets.
User picture
  on 2011-07-08 13:49 *
By David Lee
Status changed from Invalid to New
See discussion http://groups.google.com/group/liftweb/browse_thread/thread/ae461e0c7a9618c8
User picture
  on 2011-07-08 13:50 *
By David Lee
Assigned to set to nafg
User picture
  on 2011-08-04 23:49 *
By nafg
Status changed from New to Fixed
(In revision:8b02cfc891bc10e5634713c3f6cad96438ca857a) Fix #1068

Branch: master
User picture
  on 2011-08-04 23:50 *
By nafg
(In revision:9d850e7525d368bd0a446362bf190cb21c624b3c) Merge branch 'wip_1068_1072_1076'

  • wip_1068_1072_1076:
Fix #1076
Fix #1068
Fix #1072

Branch: master
User picture
  on 2011-08-05 08:50 *
By David Lee
nafg: Thanks for getting this fixed!!!

I think there's a corner case your fix doesn't handle.

If all of the oneToMany fields successfully delete, but super.delete_! fails, then the oneToMany fields will be deleted, the record you're trying to delete will remain, and the method will return false.

Should I reopen, file a new ticket, or ignore it?