#1434
  • Created on
    2013-07-08 20:15
  • Reported by
    carsten.otto
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    lrbalt
  • Milestone
    2.2.3
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Changing daily to weekly task: You must specify at least one day on which the todo recurs

I have a task that repeats every 7 days. Today I wanted to change this to once a week (every thursday), so that I get a new task for every week even if I do not check off tasks every 7 days.

The problem persists even if I pick a starting date in the future.

Changing the todo accordingly gives the message in the subject. I already applied the patch mentioned in #1431 and #1406.
User picture
  on 2013-07-08 20:15 *
By carsten.otto
Attachment weekly.png added
Attachment weekly.png added
bLFt7m5_Or4PZdacwqjQWU
screenshot
User picture
  on 2013-07-08 20:15 *
By carsten.otto
Component set to User interface (js)
Component set to User interface (js)
User picture
  on 2013-07-08 20:15 *
By carsten.otto
Version changed from 2.0 to 2.2.2
Version changed from 2.0 to 2.2.2
User picture
  on 2013-07-09 10:25 *
By lrbalt
You have an interesting setup :-)

could you post the logging for the update of this recurring todo?

btw, the current action is not updated by changing the recurrence pattern. The next action will be created according to the new pattern.
User picture
  on 2013-07-09 10:25 *
By lrbalt
Milestone set to 2.2.3
Milestone set to 2.2.3
User picture
  on 2013-07-15 09:15 *
By carsten.otto
Create action that repeats every 7 days:
Started POST "/tracks/recurring_todos" for IP at Mon Jul 15 09:10:53 +0200 2013
Processing by RecurringTodosController#create as JS
  Parameters: {"19"=>"i", "18"=>"r", "17"=>"r", "16"=>"u", "15"=>"c", "14"=>"e", "13"=>"r", "12"=>"=", "11"=>"w", "10"=>"e", "9"=>"i", "8"=>"v", "7"=>"_", "6"=>"e", "5"=>"c", "4"=>"r", "3"=>"u", "2"=>"o", "1"=>"s", "0"=>"_", "authenticity_token"=>"\"XXX\"", "29"=>"t", "28"=>"_", "27"=>"&", "26"=>"o", "25"=>"d", "24"=>"o", "23"=>"t", "22"=>"_", "21"=>"g", "20"=>"n", "37"=>"=", "36"=>"e", "35"=>"m", "34"=>"a", "33"=>"n", "32"=>"_", "31"=>"g", "30"=>"a", "recurring_todo"=>{"notes"=>"", "monthly_every_x_month"=>"1", "yearly_every_x_day"=>"15", "recurring_target"=>"due_date", "recurring_show_days_before"=>"0", "start_from"=>"15.07.2013", "daily_every_x_days"=>"7", "monthly_every_x_day"=>"15", "monthly_selector"=>"monthly_every_x_day", "yearly_selector"=>"yearly_every_x_day", "monthly_day_of_week"=>"1", "yearly_month_of_year2"=>"7", "monthly_every_xth_day"=>"1", "recurring_show_always"=>"0", "daily_selector"=>"daily_every_x_day", "weekly_return_monday"=>"m", "description"=>"Test", "end_date"=>"", "monthly_every_x_month2"=>"1", "number_of_occurences"=>"", "recurring_period"=>"daily", "ends_on"=>"no_end_date", "weekly_every_x_week"=>"1", "yearly_month_of_year"=>"7", "yearly_every_xth_day"=>"1", "yearly_day_of_week"=>"1"}, "utf8"=>"✓", "_source_view"=>"recurring_todo", "tag_list"=>"privat", "project_name"=>"PROJECT", "context_name"=>"CONTEXT"}
  Rendered recurring_todos/_recurring_todo.html.erb (33.8ms)
  Rendered recurring_todos/_recurring_todo_form.html.erb (92.0ms)
  Rendered recurring_todos/create.js.erb (169.3ms)
Completed 200 OK in 1498ms (Views: 180.2ms | ActiveRecord: 976.5ms)

Edit action to weekly, every 1 weeks, every thursday (or was it another day?):
Started GET "/tracks/recurring_todos/85/edit?_source_view=recurring_todo&_tag_name=&_=1373872253791" for IP at Mon Jul 15 09:10:58 +0200 2013
Processing by RecurringTodosController#edit as JS
  Parameters: {"_"=>"1373872253791", "_tag_name"=>"", "id"=>"85", "_source_view"=>"recurring_todo"}
  Rendered recurring_todos/_edit_form.html.erb (126.7ms)
  Rendered recurring_todos/edit.js.erb (156.6ms)
Completed 200 OK in 211ms (Views: 164.3ms | ActiveRecord: 9.3ms)
Started PUT "/tracks/recurring_todos/85" for IP at Mon Jul 15 09:11:07 +0200 2013
Processing by RecurringTodosController#update as JS
  Parameters: {"recurring_todo_edit_end_date"=>"", "19"=>"i", "18"=>"r", "17"=>"r", "16"=>"u", "15"=>"c", "14"=>"e", "13"=>"r", "12"=>"=", "11"=>"w", "10"=>"e", "9"=>"i", "8"=>"v", "7"=>"_", "6"=>"e", "5"=>"c", "4"=>"r", "3"=>"u", "2"=>"o", "1"=>"s", "0"=>"_", "edit_recurring_todo_tag_list"=>"privat", "authenticity_token"=>"\"XXX\"", "29"=>"t", "28"=>"_", "27"=>"&", "26"=>"o", "25"=>"d", "24"=>"o", "23"=>"t", "22"=>"_", "21"=>"g", "20"=>"n", "37"=>"=", "36"=>"e", "35"=>"m", "34"=>"a", "33"=>"n", "32"=>"_", "31"=>"g", "30"=>"a", "recurring_edit_todo"=>{"recurring_period"=>"weekly"}, "recurring_todo"=>{"notes"=>"", "monthly_every_x_month"=>"1", "yearly_every_x_day"=>"7", "recurring_target"=>"due_date", "recurring_show_days_before"=>"0", "daily_every_x_days"=>"7", "monthly_every_x_day"=>"7", "weekly_return_friday"=>"f", "monthly_day_of_week"=>"0", "yearly_month_of_year2"=>"7", "monthly_every_xth_day"=>"1", "recurring_show_always"=>"0", "daily_selector"=>"daily_every_x_day", "description"=>"Test", "monthly_every_x_month2"=>"1", "number_of_occurences"=>"", "ends_on"=>"no_end_date", "weekly_every_x_week"=>"1", "yearly_month_of_year"=>"7", "yearly_every_xth_day"=>"1", "yearly_day_of_week"=>"0"}, "utf8"=>"✓", "id"=>"85", "_source_view"=>"recurring_todo", "recurring_todo_edit_start_from"=>"15.07.2013", "project_name"=>"PROJECT", "context_name"=>"CONTEXT"}
  Rendered recurring_todos/_recurring_todo.html.erb (18.9ms)
  Rendered recurring_todos/update.js.erb (32.4ms)
Completed 200 OK in 145ms (Views: 44.4ms | ActiveRecord: 14.6ms)
User picture
  on 2013-07-18 08:54 *
By lrbalt
I think this is the same problem as you had before with creating recurring todos. I will investigate, but I'm quite low on time currently.
User picture
  on 2013-09-05 20:18 *
By lrbalt
Assigned to set to lrbalt
Status changed from New to Fixed
Assigned to set to lrbalt
Status changed from New to Fixed

In tracks-tickets:3ef55f3b1702421c15c552df91a8bd694c3e53b4 Hopfully fix #1434 by updating selectors first. Same fix as #1431 but now for update

Conflicts:
app/controllers/recurring_todos_controller.rb

Committed to: tracks-tickets

User picture
  on 2013-09-05 20:18 *
By lrbalt

In tracks-tickets:bd94135a5bc93cbb187ad164f57aabd263d36963 Hopfully fix #1434 by updating selectors first. Same fix as #1431 but now for update

Committed to: tracks-tickets

User picture
  on 2013-09-05 20:20 *
By lrbalt
Assigned to changed from lrbalt to -none-
Status changed from Fixed to New
Assigned to changed from lrbalt to -none-
Status changed from Fixed to New
could you test to see if my patch fixes this?
User picture
  on 2013-09-05 20:21 *
By lrbalt
Status changed from New to Fixed
Status changed from New to Fixed
User picture
  on 2013-09-09 12:22 *
By carsten.otto
No:

Started PUT "/tracks/recurring_todos/90" for 137.226.194.64 at Mon Sep 09 12:19:40 +0200 2013
Processing by RecurringTodosController#update as JS
  Parameters: {"context_name"=>"XXX", "19"=>"i", "18"=>"r", "17"=>"r", "16"=>"u", "15"=>"c", "14"=>"e", "13"=>"r", "12"=>"=", "11"=>"w", "10"=>"e", "authenticity_token"=>"\"XXX=\"", "_source_view"=>"recurring_todo", "29"=>"t", "28"=>"_", "27"=>"&", "26"=>"o", "25"=>"d", "24"=>"o", "23"=>"t", "22"=>"_", "21"=>"g", "20"=>"n", "37"=>"=", "36"=>"e", "35"=>"m", "34"=>"a", "33"=>"n", "32"=>"_", "31"=>"g", "30"=>"a", "edit_recurring_todo_tag_list"=>"privat", "project_name"=>"XXX", "recurring_todo"=>{"daily_every_x_days"=>"7", "description"=>"XXX", "monthly_every_x_day"=>"7", "yearly_every_x_day"=>"7", "daily_selector"=>"daily_every_x_day", "weekly_return_thursday"=>"t", "monthly_every_xth_day"=>"1", "yearly_month_of_year2"=>"9", "monthly_day_of_week"=>"0", "yearly_every_xth_day"=>"1", "recurring_show_days_before"=>"0", "notes"=>"", "number_of_occurences"=>"", "weekly_every_x_week"=>"1", "yearly_month_of_year"=>"9", "yearly_day_of_week"=>"0", "recurring_show_always"=>"0", "ends_on"=>"no_end_date", "monthly_every_x_month2"=>"1", "monthly_every_x_month"=>"1", "recurring_target"=>"due_date"}, "9"=>"i", "8"=>"v", "7"=>"_", "6"=>"e", "5"=>"c", "4"=>"r", "3"=>"u", "2"=>"o", "1"=>"s", "0"=>"_", "id"=>"90", "recurring_todo_edit_end_date"=>"", "recurring_todo_edit_start_from"=>"09.09.2013", "recurring_edit_todo"=>{"recurring_period"=>"weekly"}, "utf8"=>"✓"}
Completed 500 Internal Server Error in 248ms

NameError (undefined local variable or method `recurring_todo_params' for #<RecurringTodosController:0xb50776a4>):
  app/controllers/recurring_todos_controller.rb:93:in `update'
User picture
  on 2013-09-09 12:23 *
By carsten.otto
Assigned to set to lrbalt
Status changed from Fixed to New
Assigned to set to lrbalt
Status changed from Fixed to New
User picture
  on 2013-09-09 12:25 *
By carsten.otto
Status changed from New to Fixed
Status changed from New to Fixed
Sorry, that was the wrong branch.
User picture
  on 2013-09-13 10:16 *
By lrbalt
Hi Carsten,
What do you mean when you said "wrong branch"? Is the stack trace not correct? Is the problem solved? You set the status to fixed, so I hope it is the correct fix :-)
User picture
  on 2013-09-13 10:21 *
By carsten.otto
It is solved. I first (manually) applied the fix you committed to the master branch. This caused the problem I mentioned. However, the commit from the 2.2 branch perfectly fixes the problem in my (2.2) installation.
User picture
  on 2013-09-13 10:28 *
By lrbalt
Nice, thanks

Van: Carsten Otto (carsten.otto) [mailto:tracks-tickets@alerts.assembla.com]
Verzonden: vrijdag 13 september 2013 10:22
Aan: Reinier Balt (lrbalt)
Onderwerp: [Assembla] [Tracks-tickets] #1434: Changing daily to weekly task: You must specify at least one day on which the todo recurs