#98
  • Created on
    2007-11-02 11:37
  • Reported by
    swiss
  • Status
    Fixed
  • Priority
    High (2)
  • Assigned to
    Pernod
  • Milestone
    1.19
  • Plan Level
    -
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

"All categories" link not working

The addition of the code to allow the user to choose a sub-category has broken the 'All categories' link. When selected, the user is taken back to the category menu again.
User picture
  on 2011-03-30 18:41 *
By swiss
Status changed from New to closed
(In revision:844) The top-level pages for choosing a music/movie/photo category used !empty() to determine if a category had been selected, and 'All Categories' used a category ID of -1 to denote a special case.

However, sub-categories now use negative numbers (why?) and the 'All categories' ID was changed to zero.

The empty() function considers zero to be empty and therefore zero could not be used to denote a category ID. I have changed the use of !empty() to isset() instead. This achieves the desired behaviour.

fixes* 98.
User picture
  on 2011-03-30 18:41 *
By Pernod
Replying to [comment:1 swiss]:
> However, sub-categories now use negative numbers (why?) and the 'All categories' ID was changed to zero.

The negative numbers are used to indicate that 'All categories' was selected at a sub-category level which is not an end node. This is then used to select all media from ALL sub-categories of this node.
User picture
  on 2011-04-01 20:50 *
By Pernod
Priority changed from Normal (3) to High (2)
Updating tickets (#64, #70, #83, #88, #90, #91, #96, #97, #98, #99, #100, #101)
User picture
  on 2011-04-01 21:20 *
By Pernod
Component changed from None to Media Search
Updating tickets (#248, #83, #85, #97, #98, #100, #6, #92, #106, #146, #150, #151, #165, #174, #182, #191, #217, #228, #9, #77, #78, #209, #213, #219, #229)
User picture
  on 2011-04-23 03:35 *
By Pernod
Status changed from Closed to Fixed
Updating tickets (#63, #65, #75, #84, #87, #89, #93, #185, #10, #57, #64, #69, #70, #74, #79, #80, #82, #83, #85, #86, #88, #90, #91, #96, #97, #98, #99, #100, #101, #104, #105, #109, #115, #116, #117, #120, #126, #128, #130, #131, #133, #135, #153, #163, #169, #171, #173, #179, #180, #181, #184, #187, #188, #194, #195, #198, #203, #205, #218, #220, #226, #231, #236, #239, #240, #242, #247, #252, #5, #6, #11, #20, #25, #26, #27, #29, #30, #38, #40, #42, #43, #44, #46, #49, #50, #51, #52, #53, #55, #58, #59, #60, #61, #71, #92, #102, #103, #106, #107, #108, #112, #113, #114, #118, #119, #121, #129, #137, #140, #141, #144, #145, #146, #147, #149, #150, #151, #152, #154, #156, #157, #158, #160, #161, #162, #165, #167, #168, #172, #176, #182, #183, #191, #192, #193, #196, #197, #204, #206, #210, #215, #217, #222, #228, #230, #232, #234, #235, #237, #243, #249, #1, #4, #9, #12, #13, #16, #62, #78, #164, #166, #189, #190, #199, #200, #208, #209, #211, #212, #19, #47, #48)