#2243
  • Created on
    2017-10-10 21:18
  • Reported by
    jeffloun2
  • Status
    Fixed (Completed)
  • Priority
    Highest (1)
  • Assigned to
    darrinc
  • Milestone
    6.0.0
  • Plan Level
    -
  • Estimate
    0.0
  • Due Date
    -

Attachments

Using a spatial group-by and having trackDistance=0 doesn't work with patrol hours, always return 0 patrol hours

We thought we fixed this in 5.0, but it is still happening in all the versions I tested (various 5.0.x versions, including 5.0.2 and 6.0.3a3):

To Reproduce using the Example Conservation Area:
-Create a new patrol with 2 waypoints of the same spot (11.5, -0.6), (11.5, -0.6)
-Change the times to be 1:00 and 2:00 on the waypoints
-Set the track to be generated by the waypoints
-Press "Update start and end times" on the patrol summary
-Run a Patrol-Summary Query for "Number of Patrol Hours" and "Number of Active Patrol Hours"
-Filter for the patrol id you just created.
-Run it, you should see 1Hr for each value
-Add Area group-by "Patrol Sectors"
-Should show 1 hr in sector 3, but it shows zero at the moment.
User picture
  on 2017-10-19 17:31 *
By egouge
original ticket - #1933
User picture
  on 2017-10-19 18:30 *
By egouge
fixed on 5.0 branch - rev. 6103
User picture
  on 2017-10-19 20:12 *
By egouge
CONNECT - fixed on 5.0 branch - rev. 6104
As stated in original ticket the postgresql queries seem inconsistent, so this should make all results consistent.
User picture
  on 2017-10-19 23:21 *
By egouge
Status changed from New to In-Progress
User picture
  on 2017-10-19 23:21 *
By egouge
Assigned to set to egouge
User picture
  on 2017-10-31 16:31 *
By egouge
This fix introduced a different bug fixed in rev. 6129 on 5.0, rev 6130 & 6131 on trunk
User picture
  on 2017-12-13 20:40 *
By egouge
Status changed from In-Progress to Test
User picture
  on 2017-12-15 00:26 *
By egouge
Assigned to changed from egouge to darrinc
User picture
  on 2017-12-20 17:55 *
By darrinc
Assigned to changed from darrinc to egouge
Status changed from Test to In-Progress
In 6.0.a6, I created a query based on the ticket instructions and have the query return 0 hours when the Patrol Sector Group-By is added.

Image not found...
User picture
  on 2017-12-20 18:09 *
By darrinc
UPDATE: works as expected in 5.0.3 just not the current build of 6.0.a6
User picture
  on 2017-12-22 00:30 *
By egouge
This is happening i think as a result of the multilinestring code for patrol tracks. The computeHours (GeometryUtils) function only worked with LineStrings not multi linestrings).

updated rev. 6255 & 6256
User picture
  on 2018-01-03 18:39 *
By egouge
Status changed from In-Progress to Test
User picture
  on 2018-01-10 16:34 *
By egouge
Assigned to changed from egouge to darrinc
User picture
  on 2018-01-10 22:26 *
By darrinc
Status changed from Test to Fixed (Completed)
Working as expected in 6.0.a7