#1001904
  • Created on
    2013-09-27 08:35
  • Reported by
    Patrik Nordwall
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    Iulian Dragos
  • Milestone
    Sprint
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Change not detected across projects

Scala IDE for Eclipse 3.0.2.rc01-2_10-201309241119-01826fc

Checkout akka branch wip-potential-eclipse-bug-patriknw

Open akka-actor, akka-testkit and akka-actor-tests projects in workspace.

Open: akka-actor/src/main/scala/akka/routing/DeprecatedRouting.scala

Search RoundRobinRouter, replace with RoundRobinRouter2
Save!

That should result in compilation error in akka-actor-tests project, but it doesn't.
Full build of akka-actor-tests gives compilation error.

Note that RoundRobinRouter is not used anywhere else in akka-actor.
User picture
  on 2013-09-27 09:08 *
By Mirco Dotta
Looks like an incremental compiler bug. Can you reproduce it from the command line, using sbt 0.13? If yes, the bug should be reported to the upstream project.
User picture
  on 2013-09-27 10:12 *
By Patrik Nordwall
No, sbt 0.13.0 detects the change.

I added a commit to the branch with minimized akka build to be able to try with sbt 0.13.0.
User picture
  on 2013-09-27 10:47 *
By Patrik Nordwall
I think I found something. The project dependencies are akka-actor-tests -> akka-testkit -> akka-actor
When adding an extra explicit project dependency from akka-actor-tests to akka-actor it detects the change.
User picture
  on 2013-09-27 11:19 *
By Mirco Dotta
Component set to Builder
Milestone set to Sprint
User picture
  on 2013-09-27 11:37 *
By Iulian Dragos
Thanks @patriknw, this is very helpful. I didn't manage to build your branch yet, but I think there might be something there.
User picture
  on 2013-09-30 01:39 *
By Patrik Nordwall
Attachment minimized-1001904.zip added
file:aEn68KkzSr443cacwqjQYw
User picture
  on 2013-09-30 01:41 *
By Patrik Nordwall
I created minimized projects to reproduce the problem, see attachment.
Change name of class A in Proj1, that should result in compilation error in Proj3, but it doesn't.
User picture
  on 2013-09-30 04:01 *
By Iulian Dragos
Thanks a lot @patriknw. I can reproduce it. It is not a regression compared to 3.0.0 or 3.0.1, but still very annoying. I will look into it some more and let you know.
User picture
  on 2013-10-02 07:16 *
By Iulian Dragos
Assigned to set to Iulian Dragos
Status changed from New to Fixed

In scala-ide:8eeb650f70f68d3804cf93e6ad07ae30bbff7e3c Correctly build projects that depend through exported dependencies.

The Scala builder optimised the case where the builder was triggered with
no changes in a project, by skipping the call to the underlying Sbt builder.
This is wrong when the project has no changes itself, but a dependent project has.

Fixed #1001904.

Consider for back porting to 3.0.x

Committed to: scala-ide

User picture
  on 2013-10-08 03:22 *
By Mirco Dotta

In scala-ide:01ecd42c9902315beaeef078c977f7cbb1a66da7 Correctly build projects that depend through exported dependencies.

The Scala builder optimised the case where the builder was triggered with
no changes in a project, by skipping the call to the underlying Sbt builder.
This is wrong when the project has no changes itself, but a dependent project has.

Fixed #1001904.

Consider for back porting to 3.0.x(cherry picked from commit 8eeb650f70f68d3804cf93e6ad07ae30bbff7e3c)

Conflicts:

org.scala-ide.sdt.core/src/scala/tools/eclipse/buildmanager/sbtintegration/EclipseSbtBuildManager.scala

Committed to: scala-ide