#1001406
  • Created on
    2013-01-02 15:35
  • Reported by
    Mirko Stocker
  • Status
    Accepted
  • Priority
    Normal (3)
  • Assigned to
    -
  • Milestone
    Lithium 4.4.1
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

Organize Imports should be aware of SIP 18 scala.language imports

Organize Imports removes imports to scala.language because they appear to be unused.

A first step in support SIP 18 would be to simply ignore all imports from scala.language, and add full support for also adding these imports in a later step.
User picture
  on 2013-01-02 15:35 *
By Mirko Stocker
Assigned to set to Mirko Stocker
User picture
  on 2013-01-02 15:35 *
By Mirko Stocker
Version changed from 2.0.2-final-29 to 2.1.0-M3-210
User picture
  on 2013-01-02 17:23 *
By Mirko Stocker
Scala-Refactoring now ignores (i.e. keeps) imports to scala.language and language.
User picture
  on 2015-03-13 22:06 *
By Simon Schäfer
Assigned to changed from Mirko Stocker to -none-
Ticket assignment reverted due to inactivity.
User picture
  on 2015-09-02 17:57 *
By Simon Schäfer
Tags added auto-import
User picture
  on 2015-09-02 17:57 *
By Simon Schäfer
Version changed from 2.1.0-M3-210 to 4.1.1
Status changed from New to Accepted
User picture
  on 2015-09-23 07:28 *
By wpopielarski769697
Milestone set to Lithium 4.2.1
User picture
  on 2015-12-02 09:34 *
By wpopielarski769697
Milestone changed from Lithium 4.3 to Lithium 4.4
User picture
  on 2016-04-05 11:25 *
By Simon Schäfer
Milestone changed from Lithium 4.4 to Lithium 4.4.1
Move ticket to next milestone.
User picture
  on 2016-04-19 09:56 *
By wpopielarski769697
Mirco could you tell me what is a relation between following snippet from CompilationUnitDependencies and this ticket?

// Always add the SIP 18 language imports as required until we can handle them properly
  case Import(select @ Select(Ident(nme.scala_), `language`), feature) =>
    feature foreach (selector => addToResult(Select(select, selector.name)))
User picture
  on 2016-04-19 12:41 *
By Mirko Stocker
Sure, now whenever we find an import to scala.language, we add it to the required set of imports. This way, we don't lose any of these imports, this is just a work around until there is some way to figure out which features we'd need to import.
User picture
  on 2016-09-19 07:22 *
By wpopielarski769697
how I see it is:
if import scala.language.experimental.macros then find macro tree/type/attachment
if import scala.language.higherkinds then find types parametrized by types
if import scala.language.implicits then find apply implicit views