#1000939
  • Created on
    2012-03-16 02:32
  • Reported by
    Mirco Dotta
  • Status
    Fixed
  • Priority
    Normal (3)
  • Assigned to
    Mirco Dotta
  • Milestone
    Current
  • Plan Level
    -
  • Permission type
    Public
  • Due Date
    -

Attachments

Related Tickets

Add new subtask or bug

No semantic highlight on jar's attached sources

Semantic highlighting don't kick in on sources attached to a jar.

Also Implicit highlighting doesn't work, but we have a different ticket to track progress on that: https://scala-ide-portfolio.assembla.com/spaces/scala-ide/tickets/1001872#/associations/ticket:
User picture
  on 2012-04-04 07:45 *
By Mirco Dotta
Milestone set to Helium M1
User picture
  on 2012-05-07 03:26 *
By Mirco Dotta
Milestone changed from Helium M1 to Helium
User picture
  on 2012-10-10 05:00 *
By Mirco Dotta
Type set to Enhancement
Version changed from 2.0.0-final-29 to 2.0.2-final-29
Eclipse version changed from Helios to All
Milestone changed from Helium to Enhancements
User picture
  on 2013-02-27 02:39 *
By Mirco Dotta
I have a branch for this https://github.com/dotta/scala-ide/tree/issue/semantic-highlighting-on-attached-sources-1000939

I think it shouldn't be hard to achieve, but some refactoring is needed.
User picture
  on 2013-06-28 06:51 *
By Mirco Dotta
Version changed from 2.0.2-final-29 to 3.0.0-210
User picture
  on 2013-06-28 06:52 *
By Mirco Dotta
Fixed in version set to 4.0.0-nightly
User picture
  on 2013-06-28 06:53 *
By Mirco Dotta
Assigned to set to Mirco Dotta
User picture
  on 2013-06-28 06:53 *
By Mirco Dotta
Milestone changed from Enhancements to Current
User picture
  on 2013-06-28 06:53 *
By Mirco Dotta
PR is here
User picture
  on 2013-07-19 04:50 *
By Mirco Dotta
Status changed from New to Fixed

In scala-ide:cb87dc5a10c09c6093565a21da3d72f1171bf229 Semantic Highlighting now works on classfile source attachments

Created a `ScalaCompilationUnitEditor` that contains the logic common to
both the `ScalaSourceFileEditor` and the `ScalaClassFileEditor`. In particular,
the logic needed to install/dispose semantic highlighting is encapsulated in
`ScalaCompilationUnitEditor`.

It is worth pointing out that the initialization of the Semantic Highlighting
engine is different for the two editors. On the one hand, on an editable scala
source, semantic highlighting is triggered by the reconciler. On the other
hand, for a classfile source attachement, no reconciler is needed (because the
source file can't be edited), hence semantic highlighting needs to be forced at
initialization. This is why in `ScalaCompilationUnitEditor` we have the
following two additional abstract methods

  • `forceSemanticHighlightingOnInstallment`
  • `createSemantichHighlighter`

This commit comes with no tests because it is not possible to avoid the loading
of UI classes.

Fix #1000939

Committed to: scala-ide

User picture
  on 2013-09-02 08:58 *
By Mirco Dotta
Actually, my fix was only for supporting semantic highlighting on classfiles, not implicit highlighting. I'm opening a new ticket for the latter.
User picture
  on 2013-09-02 08:58 *
By Mirco Dotta
(Comment removed)
User picture
  on 2013-09-02 09:03 *
By Mirco Dotta
Version changed from 3.0.0-210 to 3.0.1-210
Summary changed from No semantic actions on jar's attached sources to No semantic highlight on jar's attached sources
Description changed from Both semantic and implicit ... to Semantic highlighting don't...
User picture
  on 2013-09-03 10:35 *
By Mirco Dotta

In scala-ide:8247c6465e87e85b89b6fbcd568d8215b97972fd Semantic Highlighting now works on classfile source attachments

Created a `ScalaCompilationUnitEditor` that contains the logic common to
both the `ScalaSourceFileEditor` and the `ScalaClassFileEditor`. In particular,
the logic needed to install/dispose semantic highlighting is encapsulated in
`ScalaCompilationUnitEditor`.

It is worth pointing out that the initialization of the Semantic Highlighting
engine is different for the two editors. On the one hand, on an editable scala
source, semantic highlighting is triggered by the reconciler. On the other
hand, for a classfile source attachement, no reconciler is needed (because the
source file can't be edited), hence semantic highlighting needs to be forced at
initialization. This is why in `ScalaCompilationUnitEditor` we have the
following two additional abstract methods

  • `forceSemanticHighlightingOnInstallment`
  • `createSemantichHighlighter`

This commit comes with no tests because it is not possible to avoid the loading
of UI classes.

Fix #1000939
(cherry picked from commit cb87dc5a10c09c6093565a21da3d72f1171bf229)

Conflicts:

org.scala-ide.sdt.core/src/scala/tools/eclipse/ScalaClassFileEditor.scala
org.scala-ide.sdt.core/src/scala/tools/eclipse/ScalaSourceFileEditor.scala
org.scala-ide.sdt.core/src/scala/tools/eclipse/semantichighlighting/ui/TextPresentationEditorHighlighter.scala
org.scala-ide.sdt.core/src/scala/tools/eclipse/semicolon/ShowInferredSemicolonsAction.scala

Committed to: scala-ide