Nullpointer on refactor->rename

I mark a class or just put the carrier in its name and hit the shortcut for rename. Get two errors in the log, first a:

"Rename - Refactoring " did not complete normally. Please see the log for more information.

but here I have no stacktrace but then also a nullpointer from JDT:

java.lang.NullPointerException
at org.eclipse.jdt.internal.corext.dom.NodeFinder.perform(NodeFinder.java:51)
at org.eclipse.jdt.internal.ui.refactoring.reorg.RenameLinkedMode.start(RenameLinkedMode.java:207)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run_aroundBody0(RenameJavaElementAction.java:187)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run_aroundBody1$advice(RenameJavaElementAction.java:41)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run(RenameJavaElementAction.java:1)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.doRun(RenameJavaElementAction.java:141)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run(RenameJavaElementAction.java:123)
at org.eclipse.jdt.ui.actions.RenameAction.run(RenameAction.java:115)
at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:278)
at org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:250)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.ui.commands.ActionHandler.execute(ActionHandler.java:185)
at org.eclipse.ui.internal.handlers.LegacyHandlerWrapper.execute(LegacyHandlerWrapper.java:109)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:470)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:824)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:880)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:569)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:510)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:125)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.filterEvent(Display.java:965)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3542)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1250)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1273)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)
at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1287)
at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1283)
at org.eclipse.swt.widgets.Canvas.sendKeyEvent(Canvas.java:433)
at org.eclipse.swt.widgets.Composite.keyDown(Composite.java:523)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4655)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:202)
at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:1753)
at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:1825)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4713)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:4285)
at org.eclipse.swt.widgets.Display.applicationProc(Display.java:4352)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
at org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:101)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3097)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)
at org.eclipse.equinox.launcher.Main.run(Main.java:1311)

eclipse.buildId=M20100211-1343
java.version=1.6.0_20
java.vendor=Apple Inc.
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=en_US
Framework arguments: -keyring /Users/viktor/.eclipse_keyring -showlocation
Command-line arguments: -os macosx -ws cocoa -arch x86_64 -keyring /Users/viktor/.eclipse_keyring -showlocation

Scala IDE for Eclipse 1.0.0.201008262341 org.scala-ide.sdt.feature.feature.group

Thanks
/Viktor

Leave a comment

on 2010-08-29 17:26 *

By Mirko Stocker

That's interesting, the error comes from the JDT, which obviously cannot refactor Scala code. If you use the refactor menu, do you get the same error?

on 2010-10-13 21:22 *

By demobox1

I have experienced the same problem on Helios. From the context menu for a Java source file, clicking on "Refactor -> Rename..." does nothing whatsoever, and using the keyboard shortcut Alt+Shift+R results in the NullPointerException popup mentioned, with the following stacktrace in the logs:

!ENTRY org.eclipse.ui 4 4 2010-10-13 12:38:15.748
!MESSAGE "Rename - Refactoring " did not complete normally. Please see the log for more information.

!ENTRY org.eclipse.ui 4 0 2010-10-13 12:38:15.814
!MESSAGE java.lang.NullPointerException
!STACK 0
java.lang.NullPointerException
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run_aroundBody1$advice(RenameJavaElementAction.java:41)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run(RenameJavaElementAction.java:1)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run(RenameJavaElementAction.java:101)
at org.eclipse.jdt.ui.actions.RenameAction.run(RenameAction.java:108)
...

Again, no obvious Scala IDE code visible here.

Renaming a non-Java file works fine, though.

I initially experienced this issue on with Scala IDE for Eclipse 1.0.0.201010070202 (org.scala-ide.sdt.feature.feature.group) on a 64-bit Windows Vista machine running jdk1.6.0_20 (x64) and 64-bit Helios M20100909-0800. I was also able to reproduce it on a clean download of Helios SR1 after installing
- on the first attempt, the Eclipse Weaving Service and then the Scala IDE
- on the second attempt, the Scala IDE and JDT Weaving for Scala

Reverting to the clean installation or uninstalling the two components resolves the issue, at least on the clean installation.

on 2010-10-14 14:22 *

By demobox1

Just to clarify my previous comment: this happens when attempting to refactor a Java class using the Java Perspective. So no Scala in site.
Still, since this problem only appears after installing the Scala IDE, and can be resolved by uninstalling the Scala IDE, it would appear to be the main suspect.

on 2010-10-14 16:07 *

By Mirko Stocker

Assigned to changed from misto to -none-

As this is not directly related to Scala Refactoring, I'm removing the assignment to me.

on 2010-10-16 19:13 *

By Mirko Stocker

These errors only seem to occur if I install our "JDT Weaving for Scala", if I use the official AspectJ installation, everything is fine.

on 2010-10-18 13:21 *

By demobox1

@Mirko: could you describe which components you mean by the "official AspectJ installation". I was also able to reproduce the problem with the "Eclipse Weaving Service Feature" from

http://download.eclipse.org/tools/ajdt/36/dev/update

(under "Other AJDT Tools (Optional)" in the download window), but maybe I was missing some components there.

The Eclipse Weaving Service Feature used to be enough to support the old (pre-Helios) Scala Eclipse plugin, though.

Thanks!

on 2010-10-18 13:24 *

By demobox1

To clarify: I was able to reproduce the problem installing only the "Eclipse Weaving Service Feature" and then the Scala IDE, i.e. without requiring "JDT Weaving for Scala". All dependencies should be satisfied in this way.

on 2010-10-18 13:34 *

By Mirko Stocker

Hm, here it seemed to work with installing from http://download.eclipse.org/tools/ajdt/36/dev/update and then the Scala IDE, without the JDT Weaving for Scala, just as you did.

What happens if you use the latest stable release, i.e. http://download.eclipse.org/tools/ajdt/36/update ?

on 2010-10-18 16:48 *

By demobox1

Strange?! Here's my steps:

1) Unzip eclipse-java-helios-SR1-win32-x86_64.zip (Size: 116 060 859 bytes, CRC 7403B63C) to a clean directory
2) Add
-vm
C:/Program Files/Java/jdk1.6.0_20/bin/javaw.exe
to eclipse.ini
3) Add http://download.eclipse.org/tools/ajdt/36/dev/update as an update site and install Eclipse Weaving Service Feature (identifier org.eclipse.contribution.weaving.feature.group, version 2.1.1.e36x-20101014-1500 )
4) Restart Eclipse
5) Add http://download.scala-ide.org/nightly-update-helios-2.8.0.final as an update site and install Scala IDE for Eclipse (identifier org.scala-ide.sdt.feature.feature.group, version 1.0.0.201010070202 )
6) Restart Eclipse
7) Attempt to rename a Java class in the Java Perspective
8) Bang! :-(
9) Revert to the previous configuration in the installation history (i.e. before the Scala IDE installation). This restarts Eclipse.
10) Attempt to rename the Java class again
11) Bang! again. (This is really weird. Is the Scala IDE changing the AspectJ weaving stuff?)
12) Revert to the configuration before the Eclipse Weaving Service Feature. This restarts Eclipse again.
13) Attempt to rename the Java class again
14) OK

I re-ran the steps using http://download.eclipse.org/tools/ajdt/36/update in step 3 (instead of the dev update site), as suggested. This pulls in version 2.1.0.e36x-release-20100630-1500 of the Weaving Service, but the results were the same.

One further thing: if I then reinstall Eclipse Weaving Service everything works fine, so it would seem that the initial configuration revert doesn't fully clean up.

on 2010-10-18 17:43 *

By Mirko Stocker

> One further thing: if I then reinstall Eclipse Weaving Service everything works fine, so it would seem that the initial configuration revert doesn't fully clean up.

Uh :-( I also reverted configurations when trying to reproduce the error.. I'm going to try again it with lots of fresh Eclipses :-)

on 2010-10-19 16:10 *

By Mirko Stocker

Ok, I've got it!

Take a look at this aspect here:

http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.ajdt/AJDT_src/org.eclipse.contribution.weaving.jdt/src/org/eclipse/contribution/jdt/refactoring/RenameJavaElementActionAspect.aj?annotate=1.2&root=Tools_Project

The NPE we see occurs on line 41, and as the comment on line 26 says, `provider` is null if the weaving service is installed but not AJDT...

I've reported this as https://bugs.eclipse.org/bugs/show_bug.cgi?id=328113

on 2010-10-31 22:33 *

By demobox1

Status changed from New to Test

Just tested with Scala IDE for Eclipse 1.0.0.201010070202 and the Eclipse Weaving Service Feature 2.1.2.e36x-20101029-1600 and everything seems to be working now ;-)