#1000097
- Created on2010-08-04 15:40
- Reported by
- StatusFixed
- PriorityNormal (3)
- Assigned to
- Milestone
- Plan Level-
- Due Date-
Refactoring unavailable via context menu and default Mac key bindings
Eclipse: 3.6.2-M20110210-1200 (Mac/Cocoa/x86_64)
Scala IDE: 2.0.0.201106012217
With working refactoring support installed, refactoring seems unavailable if I use the context menu or the default key bindings on Mac OS instead of the the menu bar. For instance, if I select a val identifier, and try to rename it using the default Mac keyboard shortcut (Cmd+Alt+R), I get an error message (_Operation unavailable on the current selection_). Same if I try the context menu: Refactoring > No refactoring available.
Scala IDE: 2.0.0.201106012217
With working refactoring support installed, refactoring seems unavailable if I use the context menu or the default key bindings on Mac OS instead of the the menu bar. For instance, if I select a val identifier, and try to rename it using the default Mac keyboard shortcut (Cmd+Alt+R), I get an error message (_Operation unavailable on the current selection_). Same if I try the context menu: Refactoring > No refactoring available.
Leave a comment
file:cqEHmKexOr4jRPeJe5cbLA: Tweaked refactoring key bindings on Mac to conform to JDT behaviour
Thanks, i'll test (for non regression on Linux).
on 2010-12-29 05:50 *
By David Bernard
(In revision:3dd0f06a8fc26a5ee3ac931f39587bfabc8ae7b7) adaptation of : [PATCH] Tweaked refactoring key bindings on Mac to conform to JDT behaviour (see #1000097) From: Fabian Steeg
Branch:wip_exp_backport
Branch:wip_exp_backport
on 2010-12-31 00:48 *
By Fabian Steeg
Thanks for picking this up so quickly!
I've marked #1000148 as a duplicate, hope that is correct and I didn't miss anything.
I've marked #1000148 as a duplicate, hope that is correct and I didn't miss anything.
file:aVaMVIgrCr4lJueJe5cbCb: Added refactorings to editor context and quick menus (patch for wip_exp_backport)
on 2011-01-06 09:45 *
By David Bernard
AAAhhhrgs, my yesterday reply (by email) was lost, I copy paste :
Fabien,
Thanks for your patch, but I can't include it until you sign some legal paper (contact Miles).
Previous patch was few lines (and mainly configuration), so it was not an issue, but this patch is bigger and I prefer to wait Miles approbation (checking legal issue). (Sometimes, Lawyers don't help evolution)
/davidB
Fabien,
Thanks for your patch, but I can't include it until you sign some legal paper (contact Miles).
Previous patch was few lines (and mainly configuration), so it was not an issue, but this patch is bigger and I prefer to wait Miles approbation (checking legal issue). (Sometimes, Lawyers don't help evolution)
/davidB
on 2011-01-06 17:00 *
By Fabian Steeg
Thanks David, I've sent a CLA to EPFL and Miles.
on 2011-01-11 14:04 *
By Fabian Steeg
(In revision:3e3ebef55c3d396efee8817d5c047b0ccdab8374) Added refactorings to editor context and quick menus (see #1000097)
Branch:wip_exp_backport
Branch:wip_exp_backport
Updating tickets (#3255, #3262, #3271, #3277, #3279, #3287, #3313, #3317, #3318, #3320, #3329, #1000000, #1000002, #1000004, #1000005, #1000007, #1000011, #1000013, #1000018, #1000019, #1000020, #1000022, #1000023, #1000024, #1000025, #1000026, #1000028, #1000031, #1000033, #1000034, #1000037, #1000039, #1000040, #1000041, #1000057, #1000058, #1000060, #1000061, #1000063, #1000064, #1000065, #1000067, #1000070, #1000073, #1000076, #1000080, #1000082, #1000083, #1000084, #1000085, #1000087, #1000088, #1000089, #1000090, #1000092, #1000093, #1000094, #1000095, #1000097, #1000102, #1000104, #1000106, #1000108, #1000110, #1000111, #1000116, #1000124, #1000126, #1000127, #1000129, #1000132, #1000133, #1000136, #1000139, #1000143, #1000144, #1000145, #1000148, #1000149, #1000152, #1000154, #1000155, #1000157, #1000158, #1000159, #1000161, #1000169, #1000170, #1000172, #1000174, #1000176, #1000178, #1000179, #1000183, #1000185, #1000188, #1000189, #1000192, #1000196, #1000198)
on 2011-06-16 20:51 *
By Fabian Steeg
Version changed from 1.0.0-SNAPSHOT to 2.0.0-beta5-29
Eclipse version set to Helios
Description changed from Eclipse: 3.5.2-M20100211-13... to Eclipse: 3.6.2-M20110210-12...
I've tested and updated the patches for wip_experiment - would be awesome to have these fixes in the default build too.
file:dtha_0Mhmr4lLCeJe4gwI3: Tweak refactoring key bindings on Mac to conform to JDT behaviour (patch for wip_experiment)
file:dtqdBwMhmr4lLCeJe4gwI3: Add refactorings to editor context and quick menus (patch for wip_experiment)
on 2011-06-17 03:29 *
By Mirko Stocker
Assigned to changed from login to Mirko Stocker
Status changed from Test to Accepted
on 2011-06-17 03:29 *
By Mirko Stocker
Thank you very much! I'll have a look at it.
(In revision:959efc2ed4317fcc09cbaadd16b232051ea32c08) Show refactorings in the context menu and add a quick refactoring menu.
Patch by Fabian Steeg, thank you very much!
Test #1000097, Fixes #1000148, Fixes #1000452
Branch:wip_experiment
Patch by Fabian Steeg, thank you very much!
Test #1000097, Fixes #1000148, Fixes #1000452
Branch:wip_experiment
on 2011-06-21 10:30 *
By Mirko Stocker
(In revision:5af84b73796f3b158855ac73d884ca1bb04c5ddc) Show refactorings in the context menu and add a quick refactoring menu.
Patch by Fabian Steeg, thank you very much!
Test #1000097, Fixes #1000148, Fixes #1000452
Branch:wip_repl
Patch by Fabian Steeg, thank you very much!
Test #1000097, Fixes #1000148, Fixes #1000452
Branch:wip_repl