#1000075
  • Created on
    2010-07-26 07:59
  • Reported by
    Ilya Klyuchnikov
  • Status
    Invalid
  • Priority
    High (2)
  • Assigned to
    David Bernard
  • Milestone
    Backlog
  • Plan Level
    -
  • Permission type
    None
  • Due Date
    -

Attachments

jdt weaving used in sdt for eclipse 3.6 breaks java refactoring

I installed sdt for eclipse 3.6 using link provided by mgm in this thicket:
http://www.assembla.com/spaces/scala-ide/tickets/3251


I have found that after installing of this build refactoring in java code doesn't work anymore.
For example, I try to rename a variable by means of standard Alt+Cmd+R
and get an exception (see below).

After disabling jdt weaving (that came with sdt) java refactoring works as before. Please fix this issue with broken weaving. Thanks.

After installing mentioned sdt i have plugin org.eclipse.equinox.weaving.hook 1.0.0v20100503 - seems that it is a custom build.

The latest AJDT 2.1.0 for eclipse 3.6 has org.eclipse.equinox.weaving.hook 1.0.0v20100108

An exception I get is the following:

"Rename - Refactoring " did not complete normally.  Please see the log for more information.

java.lang.NullPointerException
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run_aroundBody1$advice(RenameJavaElementAction.java:35)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run(RenameJavaElementAction.java:1)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.doRun(RenameJavaElementAction.java:148)
at org.eclipse.jdt.internal.ui.refactoring.actions.RenameJavaElementAction.run(RenameJavaElementAction.java:129)
at org.eclipse.jdt.ui.actions.RenameAction.run(RenameAction.java:115)
at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:278)
at org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:250)
at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
at org.eclipse.ui.commands.ActionHandler.execute(ActionHandler.java:185)
at org.eclipse.ui.internal.handlers.LegacyHandlerWrapper.execute(LegacyHandlerWrapper.java:109)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:468)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:786)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:885)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:567)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:508)
at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:123)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1031)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3775)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1367)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1390)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1375)
at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1404)
at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1400)
at org.eclipse.swt.widgets.Canvas.sendKeyEvent(Canvas.java:416)
at org.eclipse.swt.widgets.Composite.keyDown(Composite.java:594)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:4978)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
at org.eclipse.swt.widgets.Widget.callSuper(Widget.java:220)
at org.eclipse.swt.widgets.Widget.windowSendEvent(Widget.java:1943)
at org.eclipse.swt.widgets.Shell.windowSendEvent(Shell.java:2008)
at org.eclipse.swt.widgets.Display.windowProc(Display.java:5040)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
at org.eclipse.swt.widgets.Display.applicationSendEvent(Display.java:4582)
at org.eclipse.swt.widgets.Display.applicationProc(Display.java:4659)
at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
at org.eclipse.swt.internal.cocoa.NSApplication.sendEvent(NSApplication.java:115)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3274)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
User picture
  on 2010-08-01 09:09 *
By MattRussell
Duplicated association with ticket #1000086 was added
User picture
  on 2010-08-01 09:57 *
By rjenster
Appearently it's the JDT weaving feature that breaks JDT refactoring. I would change the priority to 'High' for this ticket, because it's really bad side-effect if one plugin breaks another plugins or base functionality, but I leave that to you.
User picture
  on 2010-08-01 11:35 *
By MattRussell
@ rjenster: It's certainly a critical issue for Scala IDE on Helios that I hope we can fix asap. (I don't know that the Scala IDE project makes use of the priority field, but feel free to set it if you like.)
User picture
  on 2010-08-01 11:47 *
By MattRussell
When I build helios branch locally after first blatting ~/.m2, I get some jars downloaded from the AJDT update site, and some from a Helios update site mirror. Perhaps they should all be obtained from the AJDT site?

[INFO] Downloading org.aspectj.weaver
[INFO] Fetching org.aspectj.weaver_1.6.9.20100629172100.jar (1.08MB of 1.39MB at 525.98kB/s) from http://download.eclipse.org/tools/ajdt/36/update/plugins/org.aspectj.weaver_1.6.9.20100629172100.jar
[INFO] Downloading org.aspectj.runtime
[INFO] Fetching org.aspectj.runtime_1.6.9.20100629172100.jar (4kB of 96.44kB at 0B/s) from http://download.eclipse.org/tools/ajdt/36/update/plugins/org.aspectj.runtime_1.6.9.20100629172100.jar
[INFO] Downloading org.eclipse.contribution.weaving.jdt
[INFO] Fetching org.eclipse.contribution.weaving.jdt_2.1.0.e36x-release-20100630-1500.jar (4kB of 79.34kB at 0B/s) from http://download.eclipse.org/tools/ajdt/36/update/plugins/org.eclipse.contribution.weaving.jdt_2.1.0.e36x-release-20100630-1500.jar
[INFO] Downloading org.eclipse.equinox.weaving.hook
[INFO] Fetching org.eclipse.equinox.weaving.hook_1.0.0.v20100503.jar.pack.gz (3.4kB of 18.28kB at 0B/s) from http://d2u376ub0heus3.cloudfront.net/eclipse/updates/3.6/R-3.6-201006080911/plugins/org.eclipse.equinox.weaving.hook_1.0.0.v20100503.jar.pack.gz
[INFO] Downloading org.eclipse.equinox.weaving.aspectj
[INFO] Fetching org.eclipse.equinox.weaving.aspectj_1.0.0.v20100503.jar.pack.gz (1.41kB of 12.64kB at 0B/s) from http://eclipse.ulak.net.tr/eclipseMirror/eclipse/updates/3.6/R-3.6-201006080911/plugins/org.eclipse.equinox.weaving.aspectj_1.0.0.v20100503.jar.pack.gz
User picture
  on 2010-08-01 13:27 *
By
@Matt Russell Equinox Aspects is part of Helios, so maybe this isn't as surprising as it seems. I'd be very surprised if that was the cause of this issue however.
User picture
  on 2010-08-02 06:15 *
By Peter Misak
Maybe it is worth to mention that refactoring does not work in Eclipse 3.5 (Galileo) either after performing update of Scala IDE from http://download.scala-ide.org/update-current.
User picture
  on 2010-08-03 18:07 *
By Anonymous
Needless to say this bug is a major showstopper. I would like to help out if I can, but the instructions for setting up a dev environment seem to be out of date w.r.t. Maven. Can someone make those current?
User picture
  on 2010-08-03 18:10 *
By pelotom
Sorry, that last comment was from me.
User picture
  on 2010-08-04 06:23 *
By Peter Misak
Priority changed from Normal (3) to High (2)
User picture
  on 2010-08-04 12:14 *
By David Bernard
Assigned to changed from milessabin to david.bernard.31
Status changed from New to Accepted
User picture
  on 2010-08-05 02:59 *
By David Bernard
Related association with ticket #1000095 was added
User picture
  on 2010-08-05 02:59 *
By David Bernard
The main cause is a bug in jdt-weaving :
https://bugs.eclipse.org/bugs/show_bug.cgi?id=321829
User picture
  on 2010-08-05 03:02 *
By David Bernard
A possible (not tested) workaround is to install AJDT (core + ui)
http://www.eclipse.org/ajdt/downloads/

Else, we could provide an optional plugin to register fake adapter. This plugin should not be installed near AJDT
User picture
  on 2010-08-05 15:57 *
By Peter Misak
Possible workaround suggested by David Bernard tested on Eclipse 3.5 and it works
(tested with AspectJ Development Tools 2.1.0.e35x-release-20100630-1500 org.eclipse.ajdt.feature.group).
User picture
  on 2010-08-05 16:16 *
By David Bernard
FYI fix is part of the next version of eclipse JDT-weaving (feature from AJDT)
User picture
  on 2010-08-07 04:20 *
By Peter Misak
Duplicated association with ticket #1000100 was added
User picture
  on 2010-08-08 13:05 *
By Anonymous
Related association with ticket #1000095 was removed
User picture
  on 2010-08-09 12:54 *
By Anonymous
I was having this issue until this morning, when I upgraded to ...08090106.

Now I can't even bring up the "rename" dialog! In the workspace log I get an entry "Unhandled event loop exception" in "org.eclipse.ui"
User picture
  on 2010-08-09 13:06 *
By Anonymous
Correction: 'F2' still causes the NullPointerException.

"Refactor | Rename" causes the "Unhandled event loop" error, where previously it causes the NPE.
User picture
  on 2010-08-09 15:49 *
By Anonymous
More details... oddly, does not affect .scala files. Definitely affects .java in plain old Java Projects.

Installed "AspectJ Development Tools" 2.1.0.e35x_release-20100630-1500 as per David Bernard, seems to have fixed it.
User picture
  on 2010-08-12 09:00 *
By maciejb
Shouldn't this be marked as fixed?

AJDT dev builds already contain the patch:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=321829

And looking at the revision log they're already integrated:
https://www.assembla.com/code/scala-ide/git/changesets/d50d5b161497ca02d53d2b2448179cf0550fd18e
"Use AJDT 2.1.1 development build to avoid various NPEs in the JDT."
User picture
  on 2010-08-12 09:10 *
By
Status changed from Accepted to Fixed
Indeed it should ...
User picture
  on 2010-08-12 12:34 *
By rgitzel
Status changed from Fixed to New
I was "anonymous" above.

Just uninstalled AJDT, and the problem came back (i.e. F2 of .java file causes NPE). Then upgraded Scale IDE and "JDT Weaving for Scala" to 1.0.0.201008120350. Did not seem to bring in any new dependencies (though not sure it should have).

And... still NPE on F2 of .java files. :-( And interestingly I can't seem to re-install AJDT? Some kind of missing dependency.

FYI, I'm using Eclipse 3.5, build 20100218-1602.
User picture
  on 2010-08-12 12:37 *
By MattRussell
@rgitzel: Do you still get these problems if you install Scala IDE into a clean Eclipse install?
User picture
  on 2010-08-12 14:01 *
By David Bernard
Status changed from New to Accepted
Yesterday, I did not switch the status to 'ready to test' because I wait the nightly generation witth "fix" to be available.
Currently the fix is only deployed for 3.6 (by AJDT dev team), and should be linked by the last night update-site generation.

I'll test it later this week.
User picture
  on 2010-08-13 12:00 *
By Anonymous
@MattRussell - unfortunately don't have time right now to try. :(

Did finally sort out the dependency issue: I couldn't install "AspectJ Development Tools" while that one "JDT Weaving for Scala" was installed. I removed Scala IDE completely, installed AJDT, then pulled Scala IDE back in without the weaving plugin, and so far so good.
User picture
  on 2010-09-11 10:20 *
By Anonymous
Workaround proposed by previous post also worked for me. (Mac OS X, Eclipse 3.6)
User picture
  on 2010-09-14 16:03 *
By Anonymous
Anon's workaround does stop the break of Scala refactoring. However the full Aspect/J installation ( AspectJ Development Tools 2.1.1.e36x-20100908-0800 org.eclipse.ajdt.feature.group) on Helios seems to break on: Preferences -> Java -> Build Path -> Classpath Variables which raises an NPE. See https://bugs.eclipse.org/bugs/show_bug.cgi?format=multiple&id=244347 . Just something to bear in mind...
User picture
User picture
User picture
  on 2012-01-06 04:55 *
By skyluc
Status changed from Accepted to Invalid
Closing as invalid.

Work has been in 2.0.0 final so it doesn't requires the JDT weaving plug-in anymore, fixing problem like this one. See #1000780.

Please reopen with additional information if you still see the problem.